You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/09/18 02:04:34 UTC

[GitHub] [rocketmq-client-cpp] ifplusor commented on a change in pull request #185: replace boost log with spdlog, use this PR to replace https://github.com/apache/rocketmq-client-cpp/pull/163

ifplusor commented on a change in pull request #185: replace boost log with spdlog, use this PR to replace https://github.com/apache/rocketmq-client-cpp/pull/163
URL: https://github.com/apache/rocketmq-client-cpp/pull/185#discussion_r325453245
 
 

 ##########
 File path: src/common/UtilAll.h
 ##########
 @@ -82,9 +87,9 @@ inline void deleteAndZero(Type& pointer) {
 }
 #define EMPTY_STR_PTR(ptr) (ptr == NULL || ptr[0] == '\0')
 #ifdef WIN32
-#define SIZET_FMT "%lu"
+#define SIZET_FMT "{}"
 
 Review comment:
   don't change SIZET_FMT.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services