You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/27 13:29:59 UTC
[GitHub] [incubator-apisix] membphis opened a new pull request #1169:
feature: supported key-based authentication to the dashboard.
membphis opened a new pull request #1169: feature: supported key-based authentication to the dashboard.
URL: https://github.com/apache/incubator-apisix/pull/1169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming merged pull request #1169: feature:
supported key-based authentication to the dashboard.
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #1169: feature: supported key-based authentication to the dashboard.
URL: https://github.com/apache/incubator-apisix/pull/1169
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on a change in pull request
#1169: feature: supported key-based authentication to the dashboard.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #1169: feature: supported key-based authentication to the dashboard.
URL: https://github.com/apache/incubator-apisix/pull/1169#discussion_r385563295
##########
File path: conf/config.yaml
##########
@@ -39,6 +39,7 @@ apisix:
# - 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default.
# - "::/64"
# port_admin: 9180 # use a separate port
+ token_admin: 33926bc55db5e2c3 # default token when use API to call for Admin API
Review comment:
all done, please take a look when you have time ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on a change in pull request
#1169: feature: supported key-based authentication to the dashboard.
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #1169: feature: supported key-based authentication to the dashboard.
URL: https://github.com/apache/incubator-apisix/pull/1169#discussion_r385482870
##########
File path: conf/config.yaml
##########
@@ -39,6 +39,7 @@ apisix:
# - 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default.
# - "::/64"
# port_admin: 9180 # use a separate port
+ token_admin: 33926bc55db5e2c3 # default token when use API to call for Admin API
Review comment:
1. we need add doc in the admin API
2. we need to change examples of admin API
3. better more strong default token
4. It is strongly recommended ithat users modify this default value. How about write in doc and comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services