You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by karthijrk <gi...@git.apache.org> on 2016/02/23 22:34:46 UTC
[GitHub] incubator-hawq pull request: Karthifoyzur hawq 368
GitHub user karthijrk opened a pull request:
https://github.com/apache/incubator-hawq/pull/375
Karthifoyzur hawq 368
Fixing the runaway query termination. HAWQ issue link - https://issues.apache.org/jira/browse/HAWQ-368
@gcaragea @armenatzoglou @foyzur please take a look when you get chance
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/karthijrk/incubator-hawq karthifoyzur-HAWQ-368
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/375.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #375
----
commit dbec949620be482c1dd0b5d2cb377e5cb8bd1a04
Author: hubertzhang <hz...@pivotal.io>
Date: 2016-02-23T09:35:24Z
HAWQ-440. Fix bug in pg_regress of commit HAWQ-432.
commit 214e0b7f3fa8478ce336a54de2243c51dfeccd0d
Author: Foyzur Rahman <fr...@gmail.com>
Date: 2016-02-23T19:59:12Z
fixing runaway query termination exception
closes #443
Signed-off-by: Karthikeyan Jambu Rajaraman <ka...@gmail.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Karthifoyzur hawq 368
Posted by karthijrk <gi...@git.apache.org>.
Github user karthijrk closed the pull request at:
https://github.com/apache/incubator-hawq/pull/375
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Karthifoyzur hawq 368
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/375#discussion_r53857118
--- Diff: src/test/regress/pg_regress_main.c ---
@@ -108,12 +108,7 @@ static void
psql_init(void)
{
/* set default regression database name */
- if (!dblist)
--- End diff --
why is the if check not needed anymore? can't psql_init be called a second time when dblist is not null?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: Karthifoyzur hawq 368
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/375#discussion_r53856594
--- Diff: src/backend/tcop/postgres.c ---
@@ -4652,7 +4652,22 @@ PostgresMain(int argc, char *argv[], const char *username)
}
IdleTracker_DeactivateProcess();
- firstchar = ReadCommand(&input_message);
+ /*
+ * During read command, if we have any exception we want to reactivate the process
+ * before falling back to postgres main exception handler.
+ */
+ PG_TRY();
+ {
+ firstchar = ReadCommand(&input_message);
+ }
+ PG_CATCH();
+ {
+ IdleTracker_ActivateProcess();
+ elog(LOG, "Caught exception while reading command");
+ PG_RE_THROW();
+ }
+ PG_END_TRY();
--- End diff --
fix indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---