[GitHub] hughhhh commented on a change in pull request #6399: Fix adhoc metrics in Polygon

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #6399: Fix adhoc metrics in Polygon
URL: https://github.com/apache/incubator-superset/pull/6399#discussion_r234348576
 
 

 ##########
 File path: superset/assets/src/visualizations/deckgl/layers/common.jsx
 ##########
 @@ -38,13 +38,16 @@ export function commonLayerProps(formData, setTooltip, onSelect) {
   let tooltipContentGenerator;
   if (fd.js_tooltip) {
     tooltipContentGenerator = sandboxedEval(fd.js_tooltip);
-  } else if (fd.line_column && fd.line_type === 'geohash') {
-    tooltipContentGenerator = o => (
-      <div>
-        <div>{fd.line_column}: <strong>{o.object[fd.line_column]}</strong></div>
-        {fd.metric &&
-          <div>{fd.metric}: <strong>{o.object[fd.metric]}</strong></div>}
-      </div>);
+  } else if (fd.line_column && (fd.line_type === 'geohash' || fd.line_type === 'zipcode')) {
 
 Review comment:
   add `fd.metric` to else if condition. Is there any reason why it is separate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org