[jira] [Comment Edited] (THRIFT-5109) Misc CMake improvements

["Jens Geyer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046955#comment-17046955 ] 

Jens Geyer edited comment on THRIFT-5109 at 2/27/20 9:48 PM:
-------------------------------------------------------------

PR 2021, 2025 and 2026 break the appveyor build.

Seems as if the EXE is created by MSVC in the /Debug subfolder but later on expected without /Debug at the copy step, which therefore fails.

 


was (Author: jensg):
pr 2021, 2025 and 2026 break the appveyor build.

> Misc CMake improvements
> -----------------------
>
>                 Key: THRIFT-5109
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5109
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process
>            Reporter: Jens Geyer
>            Assignee: Mario Emmenlauer
>            Priority: Major
>             Fix For: 0.14.0
>
>
>  * compiler/cpp/CMakeLists.txt: Install compiler after build, like automake does
>  * Added NodeJS to cmake build
>  * Added Javascript to cmake build
>  * build/cmake/DefineInstallationPaths.cmake: fixed the library path
>  * build/cmake/ThriftMacros.cmake: do not enforce debug suffix 'd' 
>  * lib/java/CMakeLists.txt: allow to override JAVA_INSTALL_DIR 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)