You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Karsten Beyer (JIRA)" <ji...@apache.org> on 2008/06/05 16:13:45 UTC
[jira] Created: (SHINDIG-348) GadgetContext should respect nocache
directive in gadget URL
GadgetContext should respect nocache directive in gadget URL
------------------------------------------------------------
Key: SHINDIG-348
URL: https://issues.apache.org/jira/browse/SHINDIG-348
Project: Shindig
Issue Type: Improvement
Components: Gadget Rendering Server (PHP)
Environment: Max OS X, lighttpd, Partuza
Reporter: Karsten Beyer
Priority: Trivial
If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
I think that Shindig should respect the nocache in a gadget URL.
Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (SHINDIG-348) GadgetContext should
respect nocache directive in gadget URL
Posted by "Karsten Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602742#action_12602742 ]
karsten.beyer edited comment on SHINDIG-348 at 6/5/08 11:48 AM:
----------------------------------------------------------------
Hmm. It seems that we are talking about two different issues. Passing of the parameters and even encoding (or better not encoding) works just fine with lighttpd.
If i append the ?nocache=1 to the partuza URL of for example the profile page, this is propagated to the gadget just fine. However this document:
http://www.imeem.com/developers/documentation/os/osdev
describes a way to disable the cache for an application during development by adding the ?nocache=1 to the gadget URL (the URL of the XML file). e.g. http://www.labpixies.com/campaigns/todo/todo.xml?nocache=1. This parameter is obviously urlencoded inside the url parameter of the iframe request url:
http://shindig.kbsilver/gadgets/ifr?synd=default&container=default&viewer=4&owner=4&aid=35&mid=76&country=US&lang=EN&view=home
&parent=http%3A%2F%2Fpartuza.kbsilver&st=PVLpSkznN%2FHsbqhdLCf5dNYodD9i6WBQ0xeSYSnl181
CF86owdRq2IsLZh9u0goSBUiYXoH7O1nk1CnTo1n2sztyxtmDsc2Uan3AbFr0y45cLb6E2Qeq1cd9BUnNax
1u0WAfyFoa4GuRO6FFfl2LRaOL6vRSmEVRl%2B51TnmsiRjSL21E5t92%2Fg%2FZ3Wg%2FlhwqQ1NcG
oq8TaIUVSaHSE0ihFgf%2ByBn1q10c8RCbFZGR316Cgo3&v=70f7d645865ea75d4350e46a95550728
&url=http%3A%2F%2Fopensocial.kbsilver%2Fhellosocialworld2.xml%3Fnocache%3D1#rpctoken=1112629637
The submitted patch will use this parameter to disable caching in addition to the one in the partuza url.
EDIT: inserted line breaks into url....
was (Author: karsten.beyer):
Hmm. It seems that we are talking about two different issues. Passing of the parameters and even encoding (or better not encoding) works just fine with lighttpd.
If i append the ?nocache=1 to the partuza URL of for example the profile page, this is propagated to the gadget just fine. However this document:
http://www.imeem.com/developers/documentation/os/osdev
describes a way to disable the cache for an application during development by adding the ?nocache=1 to the gadget URL (the URL of the XML file). e.g. http://www.labpixies.com/campaigns/todo/todo.xml?nocache=1. This parameter is obviously urlencoded inside the url parameter of the iframe request url:
http://shindig.kbsilver/gadgets/ifr?synd=default&container=default&viewer=4&owner=4&aid=35&mid=76&country=US&lang=EN&view=home&parent=http%3A%2F%2Fpartuza.kbsilver&st=PVLpSkznN%2FHsbqhdLCf5dNYodD9i6WBQ0xeSYSnl181CF86owdRq2IsLZh9u0goSBUiYXoH7O1nk1CnTo1n2sztyxtmDsc2Uan3AbFr0y45cLb6E2Qeq1cd9BUnNax1u0WAfyFoa4GuRO6FFfl2LRaOL6vRSmEVRl%2B51TnmsiRjSL21E5t92%2Fg%2FZ3Wg%2FlhwqQ1NcGoq8TaIUVSaHSE0ihFgf%2ByBn1q10c8RCbFZGR316Cgo3&v=70f7d645865ea75d4350e46a95550728&url=http%3A%2F%2Fopensocial.kbsilver%2Fhellosocialworld2.xml%3Fnocache%3D1#rpctoken=1112629637
The submitted patch will use this parameter to disable caching in addition to the one in the partuza url.
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-348) GadgetContext should respect
nocache directive in gadget URL
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602679#action_12602679 ]
Chris Chabot commented on SHINDIG-348:
--------------------------------------
Hmm i'm curious now.
I first checked partuza's code, and i see that it adds a normal &nocache=1 to the iframe url, and there's no urlencode()'ing going on, so it should just arrive in the $_GET normally right?
Then i checked here locally, and when i add ?nocache=1 to the partuza url, it puts that &nocache=1 in the iframe urls, and double checked that it is honored, and it is.
So in the case of apache + php, it seems to work fine as is..
Maybe this is a lightttpd only issue, that lighttpd is being to smart and encoding stuff for you? If so you might have a bigger problem then just the nocache param, since there's a -lot- of params that can be parsed on the url (container, mid, country, lang, view, parent, st, v, and user prefs).. do those propagate to the gadgetcontext for you or are they also urlencoded and hence not being picked up?
It might be a larger issue then if that is the case, and might warrant a more global solution?
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-348) GadgetContext should respect
nocache directive in gadget URL
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602782#action_12602782 ]
Chris Chabot commented on SHINDIG-348:
--------------------------------------
Yep that's indeed an option, filed a bug for that bit under the partuza project since that has no business in shindig's jira :)
http://code.google.com/p/partuza/issues/detail?id=3
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-348) GadgetContext should respect
nocache directive in gadget URL
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602779#action_12602779 ]
Kevin Brown commented on SHINDIG-348:
-------------------------------------
Sounds like something that you might want to consider supporting in partuza, though.
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-348) GadgetContext should respect
nocache directive in gadget URL
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602778#action_12602778 ]
Chris Chabot commented on SHINDIG-348:
--------------------------------------
ps if you did want to do this on a container level that would obviously quite easy, just scan the gadget url for the ?nocache=1, and add it to the gadget iframe url .. no need to do this on the gadget rendering level
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-348) GadgetContext should respect
nocache directive in gadget URL
Posted by "Karsten Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602742#action_12602742 ]
Karsten Beyer commented on SHINDIG-348:
---------------------------------------
Hmm. It seems that we are talking about two different issues. Passing of the parameters and even encoding (or better not encoding) works just fine with lighttpd.
If i append the ?nocache=1 to the partuza URL of for example the profile page, this is propagated to the gadget just fine. However this document:
http://www.imeem.com/developers/documentation/os/osdev
describes a way to disable the cache for an application during development by adding the ?nocache=1 to the gadget URL (the URL of the XML file). e.g. http://www.labpixies.com/campaigns/todo/todo.xml?nocache=1. This parameter is obviously urlencoded inside the url parameter of the iframe request url:
http://shindig.kbsilver/gadgets/ifr?synd=default&container=default&viewer=4&owner=4&aid=35&mid=76&country=US&lang=EN&view=home&parent=http%3A%2F%2Fpartuza.kbsilver&st=PVLpSkznN%2FHsbqhdLCf5dNYodD9i6WBQ0xeSYSnl181CF86owdRq2IsLZh9u0goSBUiYXoH7O1nk1CnTo1n2sztyxtmDsc2Uan3AbFr0y45cLb6E2Qeq1cd9BUnNax1u0WAfyFoa4GuRO6FFfl2LRaOL6vRSmEVRl%2B51TnmsiRjSL21E5t92%2Fg%2FZ3Wg%2FlhwqQ1NcGoq8TaIUVSaHSE0ihFgf%2ByBn1q10c8RCbFZGR316Cgo3&v=70f7d645865ea75d4350e46a95550728&url=http%3A%2F%2Fopensocial.kbsilver%2Fhellosocialworld2.xml%3Fnocache%3D1#rpctoken=1112629637
The submitted patch will use this parameter to disable caching in addition to the one in the partuza url.
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SHINDIG-348) GadgetContext should respect nocache
directive in gadget URL
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot reassigned SHINDIG-348:
------------------------------------
Assignee: Chris Chabot
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-348) GadgetContext should respect nocache
directive in gadget URL
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-348.
----------------------------------
Resolution: Won't Fix
I had to double check but my suspicion is confirmed that this is indeed a imeem only feature, and not part of 'shindig' or the open social specification.
Every container is free to add their own tools for development as they like, and apparently imeem choose to add that feature, orkut and hi5 have other ones again, but it's something that belongs in the container code and not in the main svn repo of shindig; The java side also doesn't do this kind of nocache param parsing of the gadget url.
So while i appreciate a -lot- that your making a patch for it i'm affraid i can't accept it since it's not something that belongs in shindig, but should remain a container implementation type of thing.
Shindig aims to be a complete open social spec implementation, and nothing more. So if you feel it should be a part of the open social spec, please post on the opensocial-and-gadgets-spec list at google groups. Once it makes it into the spec we'll be happy to add it in shindig :)
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Assignee: Chris Chabot
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-348) GadgetContext should respect nocache
directive in gadget URL
Posted by "Karsten Beyer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Karsten Beyer updated SHINDIG-348:
----------------------------------
Attachment: fix-SHINDIG-348-improvement.patch
patch fixes this issue
> GadgetContext should respect nocache directive in gadget URL
> ------------------------------------------------------------
>
> Key: SHINDIG-348
> URL: https://issues.apache.org/jira/browse/SHINDIG-348
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Environment: Max OS X, lighttpd, Partuza
> Reporter: Karsten Beyer
> Priority: Trivial
> Attachments: fix-SHINDIG-348-improvement.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> If you use partuza as example social network and add a gadget with nocache=1 attached as parameter, it is not respected by the rendering server, because the URL of the gadget is encoded in the iframe URL and therefore the nocache is not available inside the globale $_GET array.
> I think that Shindig should respect the nocache in a gadget URL.
> Patch is ready and will be submitted in a while.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.