You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by al...@apache.org on 2019/07/25 19:52:59 UTC
[incubator-datasketches-cpp] branch kll_no_default_construction
updated (b801445 -> 64fc63c)
This is an automated email from the ASF dual-hosted git repository.
alsay pushed a change to branch kll_no_default_construction
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git.
from b801445 always use given allocator
new ab3715e disabled debug print
new 64fc63c slightly better comment
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
common/include/serde.hpp | 5 +++--
kll/test/kll_sketch_test.cpp | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[incubator-datasketches-cpp] 01/02: disabled debug print
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alsay pushed a commit to branch kll_no_default_construction
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit ab3715e8eb4670289991895e23733cbab68b645b
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Thu Jul 25 12:51:39 2019 -0700
disabled debug print
---
kll/test/kll_sketch_test.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kll/test/kll_sketch_test.cpp b/kll/test/kll_sketch_test.cpp
index 45e1a0c..9c8c005 100644
--- a/kll/test/kll_sketch_test.cpp
+++ b/kll/test/kll_sketch_test.cpp
@@ -189,6 +189,7 @@ class kll_sketch_test: public CppUnit::TestFixture {
auto reverse_quantiles = sketch.get_quantiles(reverse_fractions, 1001);
float previous_quantile(0);
for (int i = 0; i < 1001; i++) {
+ // expensive in a loop, just to check the equivalence here, not advised for real code
const float quantile = sketch.get_quantile(fractions[i]);
CPPUNIT_ASSERT_EQUAL(quantile, quantiles[i]);
CPPUNIT_ASSERT_EQUAL(quantile, reverse_quantiles[1000 - i]);
@@ -196,7 +197,7 @@ class kll_sketch_test: public CppUnit::TestFixture {
previous_quantile = quantile;
}
- sketch.to_stream(std::cout);
+ //sketch.to_stream(std::cout);
}
void consistency_between_get_rank_and_get_PMF_CDF() {
@@ -520,7 +521,7 @@ class kll_sketch_test: public CppUnit::TestFixture {
sketch.serialize(os);
// debug print
- sketch.to_stream(std::cout);
+ //sketch.to_stream(std::cout);
}
void copy() {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[incubator-datasketches-cpp] 02/02: slightly better comment
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alsay pushed a commit to branch kll_no_default_construction
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-cpp.git
commit 64fc63c107991cc58eb469aeb36b006b53266b09
Author: AlexanderSaydakov <Al...@users.noreply.github.com>
AuthorDate: Thu Jul 25 12:52:15 2019 -0700
slightly better comment
---
common/include/serde.hpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/common/include/serde.hpp b/common/include/serde.hpp
index 1e27acd..16f250e 100644
--- a/common/include/serde.hpp
+++ b/common/include/serde.hpp
@@ -27,10 +27,11 @@ namespace datasketches {
// serialize and deserialize
template<typename T, typename Enable = void> struct serde {
- // stream
+ // stream serialization
void serialize(std::ostream& os, const T* items, unsigned num);
void deserialize(std::istream& is, T* items, unsigned num); // items are not initialized
- // raw bytes
+
+ // raw bytes serialization
size_t size_of_item(const T& item);
size_t serialize(char* ptr, const T* items, unsigned num);
size_t deserialize(const char* ptr, T* items, unsigned num); // items are not initialized
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org