You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/31 07:27:00 UTC
[jira] [Work logged] (BEAM-5658) Enable FindBugs in dataflow java
worker code
[ https://issues.apache.org/jira/browse/BEAM-5658?focusedWorklogId=192688&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192688 ]
ASF GitHub Bot logged work on BEAM-5658:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/19 07:26
Start Date: 31/Jan/19 07:26
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7684: [BEAM-5658] Re-enable findbugs on Dataflow worker
URL: https://github.com/apache/beam/pull/7684
This fixes or suppresses all findbugs warnings on the Dataflow worker. These commits should not be squashed. In the event of a need for rollback it should be isolated as far as possible. There _are_ some actual functional changes, particularly where erroneous use of integer division is now double precision division.
If they look like potential bugs, there is a Jira filed and linked in a comment. This does _not_ enable nonnull by default, so there are 100+ potential bugs lurking.
------------------------
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/) | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 192688)
Time Spent: 10m
Remaining Estimate: 0h
> Enable FindBugs in dataflow java worker code
> --------------------------------------------
>
> Key: BEAM-5658
> URL: https://issues.apache.org/jira/browse/BEAM-5658
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently we disabled FindBugs task in worker code. We should enable if after fixing all related warnings and errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)