You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/28 09:46:51 UTC
[GitHub] [incubator-tvm] Presburger opened a new pull request #6785: fix a bug in convertSSA.
Presburger opened a new pull request #6785:
URL: https://github.com/apache/incubator-tvm/pull/6785
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
@merrymercy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] Presburger commented on pull request #6785: fix a bug in convertSSA.
Posted by GitBox <gi...@apache.org>.
Presburger commented on pull request #6785:
URL: https://github.com/apache/incubator-tvm/pull/6785#issuecomment-717884931
OK, @leandron
I find a IR look like this before Loop Partition.
```cc
for(i1: int32, 0, 36){
attr [IterVar(x.inner, (nullptr), "DataPar", "")]{
for (x.inner, 0, 9) {
if(likely(i1<18))
.....
else
.....
}
}
}
```
Loop Partition will transform this IR to
```cc
for(i1: int32, 0, 18){
attr [IterVar(x.inner, (nullptr), "DataPar", "")]{
for (x.inner, 0, 9) {
.....
}
}
}
for(i1: int32, 18, 36){
attr [IterVar(x.inner, (nullptr), "DataPar", "")]{
for (x.inner, 0, 9) {
.....
}
}
}
```
then IR pass to ConvertSSA, when visited secnd for loop 's x.inner, tvm may crash.
because try to call vector::back when the vector container is empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen merged pull request #6785: fix a bug in convertSSA.
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #6785:
URL: https://github.com/apache/incubator-tvm/pull/6785
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6785: fix a bug in convertSSA.
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #6785:
URL: https://github.com/apache/incubator-tvm/pull/6785#issuecomment-717915855
Thanks @Presburger ! It would be awesome to add a unit testcase(e.g. use the tir API to construct the loops then call the convertSSA) to cover the problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6785: fix a bug in convertSSA.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6785:
URL: https://github.com/apache/incubator-tvm/pull/6785#issuecomment-719019719
Merging for now as it is a quick case, but a testcase would still be appreciated :) Thanks @leandron @Presburger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #6785: fix a bug in convertSSA.
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #6785:
URL: https://github.com/apache/incubator-tvm/pull/6785#issuecomment-717915855
Thanks @Presburger ! It would be awesome to add a testcase to cover the problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org