You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/18 12:12:04 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #9670: [style](fe) code correct rules and name rules
morrySnow opened a new pull request, #9670:
URL: https://github.com/apache/incubator-doris/pull/9670
# Proposed changes
Issue Number: close #9404
## Problem Summary:
1. change below rules' severity to error and fix original code error:
- Need Braces
- Missing Switch Default
- Fall Through
- No Finalizer
- Member Name
- Constant Name
- Parameter Name
- LambdaParameterName
- Local Variable Name
- Class Type Parameter Name
- Static Variable Name
- Method Name
- Abbreviation As Word In Name
2. update Intellij IDEA style xml
3. add inline suppression filter to check style xml
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No Need)
5. Has document been added or modified: (No Need)
6. Does it need to update dependencies: (No)
7. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9670: [style](fe) code correct rules and name rules
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9670:
URL: https://github.com/apache/incubator-doris/pull/9670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on pull request #9670: [style](fe) code correct rules and name rules
Posted by GitBox <gi...@apache.org>.
morrySnow commented on PR #9670:
URL: https://github.com/apache/incubator-doris/pull/9670#issuecomment-1130011845
just like step 1 #9460 , all fe check style error is not related to the rules this patch care about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9670: [style](fe) code correct rules and name rules
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #9670:
URL: https://github.com/apache/incubator-doris/pull/9670#discussion_r876081224
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/util/LoadSubmitter.java:
##########
@@ -151,22 +151,22 @@ private Backend selectOneBackend() throws LoadException {
}
public static class SubmitResult {
- public String TxnId;
- public String Label;
- public String Status;
- public String ExistingJobStatus;
- public String Message;
- public String NumberTotalRows;
- public String NumberLoadedRows;
- public String NumberFilteredRows;
- public String NumberUnselectedRows;
- public String LoadBytes;
- public String LoadTimeMs;
- public String BeginTxnTimeMs;
- public String StreamLoadPutTimeMs;
- public String ReadDataTimeMs;
- public String WriteDataTimeMs;
- public String CommitAndPublishTimeMs;
- public String ErrorURL;
+ public String txnId;
Review Comment:
You can't change this.
These name must match the name in json, case sensitive.
##########
fe/fe-core/src/main/java/org/apache/doris/ha/BdbHA.java:
##########
@@ -40,14 +40,14 @@
import java.util.List;
import java.util.Set;
-public class BDBHA implements HAProtocol {
Review Comment:
How about not rename this file?
##########
fe/fe-core/src/main/java/org/apache/doris/planner/MaterializedViewSelector.java:
##########
@@ -81,7 +81,7 @@ public class MaterializedViewSelector {
// private Map<String, Set<AggregatedColumn>> aggregateColumnsInQuery = Maps.newHashMap();
private Map<Long, Set<String>> columnNamesInQueryOutput = Maps.newHashMap();
- private boolean disableSPJGView;
Review Comment:
not change it.
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -320,30 +321,30 @@ public void init(Analyzer analyzer) {
}
protected void toThrift(TPlanNode msg, TPlanNodeType nodeType) {
- Preconditions.checkState( materializedResultExprLists_.size() == children.size());
Review Comment:
still a checkstyle warning here?
##########
fe/fe-core/src/main/java/org/apache/doris/journal/bdbje/BdbjeJournal.java:
##########
@@ -55,8 +55,8 @@
* Finally, close this journal.
* This class encapsulates the read, write APIs of bdbje
*/
-public class BDBJEJournal implements Journal {
Review Comment:
How about not rename this file?
##########
fe/fe-core/src/main/java/org/apache/doris/common/proc/BdbjeProcDir.java:
##########
@@ -29,7 +29,7 @@
import java.util.TreeMap;
// SHOW PROC "/bdbje"
-public class BDBJEProcDir implements ProcDirInterface {
Review Comment:
How about not rename this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morrySnow commented on a diff in pull request #9670: [style](fe) code correct rules and name rules
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #9670:
URL: https://github.com/apache/incubator-doris/pull/9670#discussion_r876550864
##########
fe/fe-core/src/main/java/org/apache/doris/planner/SetOperationNode.java:
##########
@@ -320,30 +321,30 @@ public void init(Analyzer analyzer) {
}
protected void toThrift(TPlanNode msg, TPlanNodeType nodeType) {
- Preconditions.checkState( materializedResultExprLists_.size() == children.size());
Review Comment:
only care about error in this pr, the purpose of this pr is change some rules' s severity to error and fix all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9670: [style](fe) code correct rules and name rules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9670:
URL: https://github.com/apache/incubator-doris/pull/9670#issuecomment-1131276905
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Gabriel39 commented on pull request #9670: [style](fe) code correct rules and name rules
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on PR #9670:
URL: https://github.com/apache/incubator-doris/pull/9670#issuecomment-1130000028
Wow, do you format it using a tool? I'm refactoring date/datetime type (#9611) these days and meet lots of format problems, so I formatted so many codes **by hand.** But I think there will be many conflicts when this PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9670: [style](fe) code correct rules and name rules
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9670:
URL: https://github.com/apache/incubator-doris/pull/9670#issuecomment-1131276826
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org