[GitHub] [skywalking] wu-sheng commented on a change in pull request #3769: httpasyncclient plugin adpter for ES. if out is exit span, do not propagating context

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #3769: httpasyncclient plugin adpter for ES. if out is exit span, do not propagating context
URL: https://github.com/apache/skywalking/pull/3769#discussion_r341685074
 
 

 ##########
 File path: apm-sniffer/apm-sdk-plugin/httpasyncclient-4.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/httpasyncclient/v4/HttpAsyncRequestExecutorInterceptor.java
 ##########
 @@ -48,12 +48,14 @@
     @Override
     public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allArguments, Class<?>[] argumentsTypes, MethodInterceptResult result) throws Throwable {
         HttpContext context = CONTEXT_LOCAL.get();
+        Boolean isOutNotExit = CONTEXT_LOCAL_NOT_EXIT.get();
 
 Review comment:
   Why need this? Is this method not in the main context thread?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services