[GitHub] [kafka] vvcephei commented on a change in pull request #8508: MINOR: Improve usage of LogCaptureAppender

[GitBox <gi...@apache.org>]

vvcephei commented on a change in pull request #8508:
URL: https://github.com/apache/kafka/pull/8508#discussion_r411667311



##########
File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java
##########
@@ -84,6 +87,10 @@
 
     @Before
     public void init() {
+        // When executing on Jenkins, the thread name is set to an unknown value,
+        // hence, we need to set it explicitly to make our log-assertions pass
+        Thread.currentThread().setName(threadName);

Review comment:
       Hmm, this might be surprising. Won't this cause the test executor thread to be called "threadName" from now until the end of the build?
   
   Do you think we could instead get the currentThread's name and use that in the assertions? Or otherwise make the assertions agnostic to the name of the thread?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org