You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2023/07/03 03:52:32 UTC
[GitHub] [incubator-celeborn] cfmcgrady opened a new pull request, #1672: [CELEBORN-726][FOLLOWUP] Eliminate 'TODO' comments within the `Controller` class
cfmcgrady opened a new pull request, #1672:
URL: https://github.com/apache/incubator-celeborn/pull/1672
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
eliminate comments introduced in https://github.com/apache/incubator-celeborn/pull/1650
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1672: [CELEBORN-726][FOLLOWUP] Eliminate 'TODO' comments within the `Controller` class
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1672:
URL: https://github.com/apache/incubator-celeborn/pull/1672#issuecomment-1617225345
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1672?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1672](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1672?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7917552) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/7880c52fff9586453cd923945e57cc87c1769103?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7880c52) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1672 +/- ##
==========================================
+ Coverage 46.25% 46.39% +0.15%
==========================================
Files 161 161
Lines 9963 9963
Branches 920 920
==========================================
+ Hits 4607 4621 +14
+ Misses 5053 5041 -12
+ Partials 303 301 -2
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1672/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1672: [CELEBORN-726][FOLLOWUP] Eliminate 'TODO' comments within the `Controller` class
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1672: [CELEBORN-726][FOLLOWUP] Eliminate 'TODO' comments within the `Controller` class
URL: https://github.com/apache/incubator-celeborn/pull/1672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org