You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Andrei Savu (JIRA)" <ji...@apache.org> on 2011/03/12 16:39:59 UTC
[jira] Created: (WHIRR-259) Disable configuration list handling for
Hadoop properties
Disable configuration list handling for Hadoop properties
---------------------------------------------------------
Key: WHIRR-259
URL: https://issues.apache.org/jira/browse/WHIRR-259
Project: Whirr
Issue Type: Bug
Reporter: Andrei Savu
Fix For: 0.4.0
It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (WHIRR-259) Disable configuration list handling
for Hadoop properties
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu resolved WHIRR-259.
-------------------------------
Resolution: Fixed
Assignee: Andrei Savu
I've just committed this. Thanks Tom for reviewing.
> Disable configuration list handling for Hadoop properties
> ---------------------------------------------------------
>
> Key: WHIRR-259
> URL: https://issues.apache.org/jira/browse/WHIRR-259
> Project: Whirr
> Issue Type: Improvement
> Reporter: Andrei Savu
> Assignee: Andrei Savu
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: WHIRR-259.patch
>
>
> It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-259) Disable configuration list handling for
Hadoop properties
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-259:
------------------------------
Priority: Minor (was: Major)
Issue Type: Improvement (was: Bug)
> Disable configuration list handling for Hadoop properties
> ---------------------------------------------------------
>
> Key: WHIRR-259
> URL: https://issues.apache.org/jira/browse/WHIRR-259
> Project: Whirr
> Issue Type: Improvement
> Reporter: Andrei Savu
> Priority: Minor
> Fix For: 0.4.0
>
> Attachments: WHIRR-259.patch
>
>
> It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-259) Disable configuration list handling
for Hadoop properties
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006259#comment-13006259 ]
Andrei Savu commented on WHIRR-259:
-----------------------------------
Tom, I've tried that approach. It would be great if common-configuration would provide a way of retrieving the original property value (before splitting).
> Disable configuration list handling for Hadoop properties
> ---------------------------------------------------------
>
> Key: WHIRR-259
> URL: https://issues.apache.org/jira/browse/WHIRR-259
> Project: Whirr
> Issue Type: Bug
> Reporter: Andrei Savu
> Fix For: 0.4.0
>
> Attachments: WHIRR-259.patch
>
>
> It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-259) Disable configuration list handling
for Hadoop properties
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006323#comment-13006323 ]
Tom White commented on WHIRR-259:
---------------------------------
I can't see another way of doing this either. +1 to the patch.
> Disable configuration list handling for Hadoop properties
> ---------------------------------------------------------
>
> Key: WHIRR-259
> URL: https://issues.apache.org/jira/browse/WHIRR-259
> Project: Whirr
> Issue Type: Bug
> Reporter: Andrei Savu
> Fix For: 0.4.0
>
> Attachments: WHIRR-259.patch
>
>
> It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-259) Disable configuration list handling
for Hadoop properties
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006111#comment-13006111 ]
Tom White commented on WHIRR-259:
---------------------------------
Another way of doing this would be to call setDelimiterParsingDisabled(true), according to http://commons.apache.org/configuration/howto_basicfeatures.html#List_handling. However, we only want to do this for the Hadoop configuration, since we use lists for instance templates.
> Disable configuration list handling for Hadoop properties
> ---------------------------------------------------------
>
> Key: WHIRR-259
> URL: https://issues.apache.org/jira/browse/WHIRR-259
> Project: Whirr
> Issue Type: Bug
> Reporter: Andrei Savu
> Fix For: 0.4.0
>
> Attachments: WHIRR-259.patch
>
>
> It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WHIRR-259) Disable configuration list handling
for Hadoop properties
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006066#comment-13006066 ]
Tom White commented on WHIRR-259:
---------------------------------
I wonder why list escaping doesn't work - ideally we would get this working so we stick to the contract of http://commons.apache.org/configuration/howto_properties.html. But if there's a bug there then this workaround seems OK.
> Disable configuration list handling for Hadoop properties
> ---------------------------------------------------------
>
> Key: WHIRR-259
> URL: https://issues.apache.org/jira/browse/WHIRR-259
> Project: Whirr
> Issue Type: Bug
> Reporter: Andrei Savu
> Fix For: 0.4.0
>
> Attachments: WHIRR-259.patch
>
>
> It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WHIRR-259) Disable configuration list handling for
Hadoop properties
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-259:
------------------------------
Attachment: WHIRR-259.patch
This patch joins the lists using the default delimiter for hadoop specific configuration options. It's not possible to completely disable list handling (e.g. whirr.instance-templates).
> Disable configuration list handling for Hadoop properties
> ---------------------------------------------------------
>
> Key: WHIRR-259
> URL: https://issues.apache.org/jira/browse/WHIRR-259
> Project: Whirr
> Issue Type: Bug
> Reporter: Andrei Savu
> Fix For: 0.4.0
>
> Attachments: WHIRR-259.patch
>
>
> It seems like escaping doesn't always work so I believe that we should completely disable list handling or rebuild the original strings for Hadoop specific configuration options.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira