You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/22 17:07:21 UTC
[jira] [Commented] (PROTON-1283) Adds support for transport layers
not currently implemented in the library
[ https://issues.apache.org/jira/browse/PROTON-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431206#comment-15431206 ]
ASF GitHub Bot commented on PROTON-1283:
----------------------------------------
Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton/pull/77
Hi Andrew,
I've created an alternative version resolving some niggles with the changes here (exposing various impl types, wildcard imports, licence header content, no tests). Its similar but you will need to cast to TransportInternal to get at the added method, as while I have no real issue with making the implementation itself support this I don't think it should be made part of the public Transport interface currently, so I took an inbetween approach.
https://github.com/gemmellr/qpid-proton/commit/d7c82bf0f14f2468d3aa2e39109003e00e3a4909
(or https://github.com/gemmellr/qpid-proton/commit/d7c82bf0f14f2468d3aa2e39109003e00e3a4909.patch to get the patch)
Give it a try out and let me know how you get on, if all is well I'll merge it to the apache master.
Robbie
(mentioning PROTON-1283 here to make this comment hit the related JIRA, as it was opened afterwards and wasn't in the original PR title)
> Adds support for transport layers not currently implemented in the library
> --------------------------------------------------------------------------
>
> Key: PROTON-1283
> URL: https://issues.apache.org/jira/browse/PROTON-1283
> Project: Qpid Proton
> Issue Type: Improvement
> Reporter: Andrew Buckley
>
> This would add the ability for users to implement their own transport layers and have it be usable by the library.
> I made a pull request last week which you can see here: https://github.com/apache/qpid-proton/pull/77
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org