You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/14 15:09:52 UTC
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6386
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
[DOCS] Genericize impala_breakpad page
Revise a couple of CM-specific paths shown in debugging example.
The edited paths are nonexistent, but that doesn't matter for
purposes of illustration.
Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
---
M docs/topics/impala_breakpad.xml
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/6386/1
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
[DOCS] Genericize impala_breakpad page
Revise a couple of CM-specific paths shown in debugging example.
The edited paths are nonexistent, but that doesn't matter for
purposes of illustration.
Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Reviewed-on: http://gerrit.cloudera.org:8080/6386
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_breakpad.xml
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Ambreen Kazi: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6386/1/docs/topics/impala_breakpad.xml
File docs/topics/impala_breakpad.xml:
PS1, Line 100: CM
CM ref.
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/92/
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
[DOCS] Genericize impala_breakpad page
Revise a couple of CM-specific paths shown in debugging example.
The edited paths are nonexistent, but that doesn't matter for
purposes of illustration.
Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
---
M docs/topics/impala_breakpad.xml
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/6386/2
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize impala breakpad page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize impala_breakpad page
......................................................................
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/93/
--
To view, visit http://gerrit.cloudera.org:8080/6386
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If45f9c549e2a0d46a7eb43c4ce09673adaae9982
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No