You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/07 13:53:54 UTC

[GitHub] [arrow] thisisnic commented on pull request #13514: ARROW-16977: [R] Update dataset row counting so no integer overflow on large datasets

thisisnic commented on PR #13514:
URL: https://github.com/apache/arrow/pull/13514#issuecomment-1177652805

   > I don't see a test of the r_vec_size() behavior in this PR or the other one. What is our assurance that it behaves as we want?
   
   I added some in an earlier version of the previous PR, but they took ages to run locally (though were successful), and on CI just crashed it entirely.  I removed them, but couldn't think of an alternative.  Do you have any suggestions?
   
   > ...Would you mind fixing them all in this PR too?
   
   Done.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org