[GitHub] [qpid-broker-j] overmeulen commented on a change in pull request #23: QPID-8294: [Broker-J][Oracle Message Store] Batch delete fails for more than 1000 messages

[GitBox <gi...@apache.org>]

overmeulen commented on a change in pull request #23: QPID-8294: [Broker-J][Oracle Message Store] Batch delete fails for more than 1000 messages
URL: https://github.com/apache/qpid-broker-j/pull/23#discussion_r272744201
 
 

 ##########
 File path: broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/AbstractJDBCMessageStore.java
 ##########
 @@ -82,6 +82,8 @@
     private static final String XID_TABLE_NAME_SUFFIX = "QPID_XIDS";
     private static final String XID_ACTIONS_TABLE_NAME_SUFFIX = "QPID_XID_ACTIONS";
 
+    private static final int MAX_DELETE_BATCH_SIZE = 1000;
 
 Review comment:
   Good idea. But to be consistent with the other system variables I propose "qpid.jdbcstore.inClauseMaxSize". I'm also changing the name to inClauseMaxSize because actually it's not really a batch here and it's not specific to the delete operation. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org