You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/23 17:05:44 UTC

[GitHub] [incubator-tvm] tqchen opened a new issue #6540: [RUST][FFI] Pass uint as int in PackedFunc

tqchen opened a new issue #6540:
URL: https://github.com/apache/incubator-tvm/issues/6540


   per PackedFunc FFI convention, we should always pass integer as i64 when they appear as argument of a PackedFunc to simplify the calling.  We might need to update the rust FFI to reflect it. 
   
   Related 
   - https://github.com/apache/incubator-tvm/issues/6528
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] intheworld commented on issue #6540: [RUST][FFI] Pass uint as int in PackedFunc

Posted by GitBox <gi...@apache.org>.
intheworld commented on issue #6540:
URL: https://github.com/apache/incubator-tvm/issues/6540#issuecomment-698116184


   I see the following code in PackedFunc. 
   impl_pod_value!(Int, i64, [i8, i16, i32, i64, isize]);
   impl_pod_value!(UInt, i64, [u8, u16, u32, u64, usize]);
   
   Inner type is i64. in #6528 , I think the problem is the inconsistence between rust Context and TVMContext.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] intheworld commented on issue #6540: [RUST][FFI] Pass uint as int in PackedFunc

Posted by GitBox <gi...@apache.org>.
intheworld commented on issue #6540:
URL: https://github.com/apache/incubator-tvm/issues/6540#issuecomment-698116184


   I see the following code in PackedFunc. 
   impl_pod_value!(Int, i64, [i8, i16, i32, i64, isize]);
   impl_pod_value!(UInt, i64, [u8, u16, u32, u64, usize]);
   
   Inner type is i64. in #6528 , I think the problem is the inconsistence between rust Context and TVMContext.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen edited a comment on issue #6540: [RUST][FFI] Pass uint as int in PackedFunc

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #6540:
URL: https://github.com/apache/incubator-tvm/issues/6540#issuecomment-697708522


   cc @jroesch @mwillsey @nhynes 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #6540: [RUST][FFI] Pass uint as int in PackedFunc

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #6540:
URL: https://github.com/apache/incubator-tvm/issues/6540#issuecomment-697708522


   cc @jroesch @mwillsey 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org