You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/08/06 13:12:08 UTC
[GitHub] storm pull request #2794: STORM-3180 Total executors in Cluster Summary in m...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2794
STORM-3180 Total executors in Cluster Summary in main UI page is not …
…exposed even a topology is running
* rename the field of /cluster/summary output: `totalExecutors` to `executorsTotal`
Please compare with doc regarding the output format of API:
https://github.com/apache/storm/blob/master/docs/STORM-UI-REST-API.md#apiv1clustersummary-get
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-3180
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2794.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2794
----
commit fdfeb14166301fed82b045f41934b693e95577c4
Author: Jungtaek Lim <ka...@...>
Date: 2018-08-06T13:07:53Z
STORM-3180 Total executors in Cluster Summary in main UI page is not exposed even a topology is running
* rename the field of /cluster/summary output: totalExecutors to executorsTotal
----
---
[GitHub] storm issue #2794: STORM-3180 Total executors in Cluster Summary in main UI ...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2794
Okay, just wanted to be sure it wasn't an oversight. +1.
---
[GitHub] storm issue #2794: STORM-3180 Total executors in Cluster Summary in main UI ...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2794
Grepping for "totalExecutors" also pops up a couple of other locations in storm-webapp.
```
./storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java:536: int totalExecutors =
./storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java:574: result.put("totalExecutors", totalExecutors);
./storm-webapp/src/main/java/org/apache/storm/daemon/ui/UIHelpers.java:631: result.put("totalExecutors", ownerResourceSummary.get_total_executors());
./storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/js/script.js:541: data: 'totalExecutors',
./storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/owner.html:148: //owner,totalTopologies,totalTasks,totalExecutors,totalWorkers
./storm-webapp/src/main/java/org/apache/storm/daemon/ui/WEB-INF/templates/owner-page-template.html:51: <td>{{totalExecutors}}</td>
```
Do any of the others also need to be changed?
---
[GitHub] storm issue #2794: STORM-3180 Total executors in Cluster Summary in main UI ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2794
@srdo No, unfortunately we don't apply consistent naming so `totalExecutors` is right for others. Renaming them would break clients which rely on the REST API, so I'm not sure we would be better to fix them though I think it is ideal to fix.
---
[GitHub] storm pull request #2794: STORM-3180 Total executors in Cluster Summary in m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2794
---