You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jmmonte2 (via GitHub)" <gi...@apache.org> on 2025/08/04 00:51:46 UTC
[PR] KAFKA-1948: Fix flaky test testConsumerGroupHeartbeatWithRegex [kafka]
jmmonte2 opened a new pull request, #20298:
URL: https://github.com/apache/kafka/pull/20298
### Description
- This change address flaky test testConsumerGroupHeartbeatWithRegex
- The reason why this test fails is due to async call within [GroupMetadataManager](https://github.com/apache/kafka/blob/trunk/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java#L3184-L3187). I addressed the issue by using TestUtils.tryUntilNoAssertionError() to allow for a retry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19481: Fix flaky test testConsumerGroupHeartbeatWithRegex [kafka]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 merged PR #20298:
URL: https://github.com/apache/kafka/pull/20298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19481: Fix flaky test testConsumerGroupHeartbeatWithRegex [kafka]
Posted by "jmmonte2 (via GitHub)" <gi...@apache.org>.
jmmonte2 commented on PR #20298:
URL: https://github.com/apache/kafka/pull/20298#issuecomment-3155330909
> lgtm, since `testConsumerGroupHeartbeatWithRegexWithTopicDescribeAclAddedAndRemoved` follows the same approach.
>
> Can we update the PR description to explain what the async operation and test failure are? It's not immediately clear unless you're familiar with regex subscriptions.
@squah-confluent thanks for the review. I went ahead and updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19481: Fix flaky test testConsumerGroupHeartbeatWithRegex [kafka]
Posted by "jmmonte2 (via GitHub)" <gi...@apache.org>.
jmmonte2 commented on PR #20298:
URL: https://github.com/apache/kafka/pull/20298#issuecomment-3160143725
@squah-confluent Thank you! I noticed the approval did not go through due to lack of write access. Do you have another reviewer I can add on?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19481: Fix flaky test testConsumerGroupHeartbeatWithRegex [kafka]
Posted by "jmmonte2 (via GitHub)" <gi...@apache.org>.
jmmonte2 commented on PR #20298:
URL: https://github.com/apache/kafka/pull/20298#issuecomment-3565017610
> @jmmonte2 could you merge the trunk branch? I will review it after CI is ready. Thank you.
@FrankYang0529 Updated. Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19481: Fix flaky test testConsumerGroupHeartbeatWithRegex [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20298:
URL: https://github.com/apache/kafka/pull/20298#issuecomment-3507490247
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19481: Fix flaky test testConsumerGroupHeartbeatWithRegex [kafka]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on PR #20298:
URL: https://github.com/apache/kafka/pull/20298#issuecomment-3509103459
@jmmonte2 could you merge the trunk branch? I will review it after CI is ready. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19481: Fix flaky test testConsumerGroupHeartbeatWithRegex [kafka]
Posted by "jmmonte2 (via GitHub)" <gi...@apache.org>.
jmmonte2 commented on PR #20298:
URL: https://github.com/apache/kafka/pull/20298#issuecomment-3172568494
@FrankYang0529 Could you please also review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org