[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3161: Update `ahash` requirement from 0.7 to 0.8

[GitBox <gi...@apache.org>]

alamb commented on code in PR #3161:
URL: https://github.com/apache/arrow-datafusion/pull/3161#discussion_r946087806


##########
datafusion/core/src/physical_plan/hash_utils.rs:
##########
@@ -43,11 +43,11 @@ fn hash_null(random_state: &RandomState, hashes_buffer: &'_ mut [u64], mul_col:
     if mul_col {
         hashes_buffer.iter_mut().for_each(|hash| {
             // stable hash for null value
-            *hash = combine_hashes(i128::get_hash(&1, random_state), *hash);
+            *hash = combine_hashes(random_state.hash_one(&1), *hash);

Review Comment:
   These changes are required due to https://github.com/tkaitchuck/aHash/pull/121 which appears to have made `CallHasher` crate private



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org