You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/04 11:56:07 UTC

[GitHub] [airflow] coopergillan commented on a change in pull request #10156: [GH-10147] Use conn_name_attr for SqliteHook connection

coopergillan commented on a change in pull request #10156:
URL: https://github.com/apache/airflow/pull/10156#discussion_r464996172



##########
File path: airflow/providers/sqlite/hooks/sqlite.py
##########
@@ -28,12 +28,12 @@ class SqliteHook(DbApiHook):
 
     conn_name_attr = 'sqlite_conn_id'
     default_conn_name = 'sqlite_default'
-    supports_autocommit = False

Review comment:
       Happy to change it, but since the `DbApiHook` has the same, is it needed? Maybe needed just to be explicit?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org