You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/19 01:22:34 UTC

[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #24: Pass the ArrowBufferAllocator by value and implement a custom deallocator

paleolimbot opened a new pull request, #24:
URL: https://github.com/apache/arrow-nanoarrow/pull/24

   This feature will allow R/Python runtimes to use the built-in `ArrowArrayInit()`/`ArrowArraySetBuffer()` infrastructure rather than roll their own (e.g., an R package could set a custom deallocator that calls `R_ReleaseObject()` on whatever object was protecting the buffer from garbage collection). Clients that are also using Arrow C++ could use this to with a shared pointer to a Buffer to avoid a copy as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #24: Pass the ArrowBufferAllocator by value and implement a custom deallocator

Posted by GitBox <gi...@apache.org>.
paleolimbot merged PR #24:
URL: https://github.com/apache/arrow-nanoarrow/pull/24


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot commented on pull request #24: Pass the ArrowBufferAllocator by value and implement a custom deallocator

Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #24:
URL: https://github.com/apache/arrow-nanoarrow/pull/24#issuecomment-1220659759

   I removed the 'allocate' method since it was never actually used, which gives us 8 bytes back! At the point anybody is doing something like `std::vector<struct ArrowBuffer>` with enough buffers for that to matter, they probably should be inventing their own structure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #24: Pass the ArrowBufferAllocator by value and implement a custom deallocator

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #24:
URL: https://github.com/apache/arrow-nanoarrow/pull/24#issuecomment-1220138527

   # [Codecov](https://codecov.io/gh/apache/arrow-nanoarrow/pull/24?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24](https://codecov.io/gh/apache/arrow-nanoarrow/pull/24?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0fe046) into [main](https://codecov.io/gh/apache/arrow-nanoarrow/commit/07880feff2117c05bb1189f605a93f42d91bc744?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (07880fe) will **increase** coverage by `0.06%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##             main      #24      +/-   ##
   ==========================================
   + Coverage   90.84%   90.90%   +0.06%     
   ==========================================
     Files          12       12              
     Lines        1365     1375      +10     
     Branches       57       57              
   ==========================================
   + Hits         1240     1250      +10     
     Misses         82       82              
     Partials       43       43              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-nanoarrow/pull/24?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [src/nanoarrow/allocator.c](https://codecov.io/gh/apache/arrow-nanoarrow/pull/24/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL25hbm9hcnJvdy9hbGxvY2F0b3IuYw==) | `100.00% <100.00%> (ø)` | |
   | [src/nanoarrow/buffer\_inline.h](https://codecov.io/gh/apache/arrow-nanoarrow/pull/24/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL25hbm9hcnJvdy9idWZmZXJfaW5saW5lLmg=) | `84.78% <100.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org