[GitHub] [maven-resolver] cstamas commented on a diff in pull request #257: [MRESOLVER-329] More robust IO in DefaultTrackingFileManager

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on code in PR #257:
URL: https://github.com/apache/maven-resolver/pull/257#discussion_r1117219091


##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/FileUtils.java:
##########
@@ -105,7 +106,16 @@ public Path getPath() {
 
             @Override
             public void move() throws IOException {
-                Files.move(tempFile, file, StandardCopyOption.ATOMIC_MOVE);
+                try {
+                    Files.move(tempFile, file, StandardCopyOption.ATOMIC_MOVE);

Review Comment:
   I might be wrong, but this is what Jenkins does as well: tries atomic, and if fails, the fallback is plain copy+rm... Naturally, this will need some triage, to see is it working at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org