[GitHub] [shardingsphere-on-cloud] wbtlb commented on a diff in pull request #318: perf(pitr): check status of agent servers before do backup

["wbtlb (via GitHub)" <gi...@apache.org>]

wbtlb commented on code in PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#discussion_r1174513028


##########
pitr/cli/internal/cmd/backup.go:
##########
@@ -253,6 +257,37 @@ func execBackup(lsBackup *model.LsBackup) error {
 	return nil
 }
 
+func checkAgentServerStatus(lsBackup *model.LsBackup) bool {
+
+	type Status struct {

Review Comment:
   I think move struct definition out of func is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org