[GitHub] flink pull request #2770: [FLINK-4354]Implement TaskManager side of heartbea...

[tillrohrmann <gi...@git.apache.org>]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2770#discussion_r99586359
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java ---
    @@ -122,4 +122,11 @@ void notifySlotAvailable(
     	 * @param optionalDiagnostics
     	 */
     	void shutDownCluster(final ApplicationStatus finalStatus, final String optionalDiagnostics);
    +
    +	/**
    +	 * sends the heartbeat to resource manager from task manager
    +	 * @param resourceID unique id of the task manager
    +	 * @param payload the payload information of the task manager
    +	 */
    +	void sendHeartbeatFromTaskManager(final ResourceID resourceID, final Object payload);
    --- End diff --
    
    Better to call this method `reportHeartbeatFromTaskManager` or `heartbeatFromTaskManager`. Maybe we could also introduce a dedicated interface for this which is inherited by the `ResourceManagerGateway`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---