[GitHub] [incubator-mxnet] szha commented on a change in pull request #20160: [v1.x][submodule] Upgrade oneDNN to v2.2

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #20160:
URL: https://github.com/apache/incubator-mxnet/pull/20160#discussion_r612498485



##########
File path: src/operator/nn/mkldnn/mkldnn_convolution.cc
##########
@@ -431,7 +431,7 @@ void MKLDNNConvolutionForwardFullFeature(const MKLDNNConvFullParam &param, const
       weight_mem = GetWeights(weight, fwd->GetPd().weights_desc(), param.conv_param.num_group);
     } else {
       weight_mem = weight.GetMKLDNNData();
-      CHECK(weight_mem->get_desc() == fwd->GetPd().weights_desc());
+      // CHECK(weight_mem->get_desc() == fwd->GetPd().weights_desc());

Review comment:
       do not leave commented code in the code base.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org