You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2018/11/21 16:28:44 UTC

[GitHub] [geode] jinmeiliao opened pull request #2889: GEODE-5943: cleanup vm before each test

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2889 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #2889: GEODE-5943: cleanup vm before each test

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/2889 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] agingade commented on pull request #2889: GEODE-5943: cleanup vm before each test

Posted by "agingade (GitHub)" <gi...@apache.org>.
I don't think we need to be using bounce to address the flakiness. We need to see where the calculation is getting wrong; if its with initial memory (before the test runs) or the memory usage/leak as the tests gets run and accordingly calculate the eviction. If its memory leak, need to address that. 
For now we could make this change to address the flakiness in the ci pipeline, but we should keep the ticket open with the comments to reproduce the issue.

[ Full content available at: https://github.com/apache/geode/pull/2889 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2889: GEODE-5943: cleanup vm before each test

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
Will keep the ticket open

[ Full content available at: https://github.com/apache/geode/pull/2889 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #2889: GEODE-5943: cleanup vm before each test

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
failure not related to this PR

[ Full content available at: https://github.com/apache/geode/pull/2889 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org