[GitHub] [spark] grundprinzip commented on a diff in pull request #38630: [SPARK-41115][CONNECT] Add ClientType Enum to proto to indicate which client sends a request

[GitBox <gi...@apache.org>]

grundprinzip commented on code in PR #38630:
URL: https://github.com/apache/spark/pull/38630#discussion_r1020553414


##########
connector/connect/src/main/protobuf/spark/connect/base.proto:
##########
@@ -48,6 +54,9 @@ message Request {
   // The logical plan to be executed / analyzed.
   Plan plan = 3;
 
+  // From which client this request was sent from.
+  ClientType client_type = 4;

Review Comment:
   To avoid changing this all the time a new client comes along, this should most likely be a string.
   ```suggestion
     optional string client_type = 4;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org