You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/10 21:14:56 UTC
[GitHub] [beam] ryanthompson591 opened a new pull request, #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
ryanthompson591 opened a new pull request, #24099:
URL: https://github.com/apache/beam/pull/24099
Add a ValidatesContainer integration test that exercises --experiments=[no]use_sibling_sdk_workers
See https://github.com/apache/beam/issues/24092
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1311137755
Run Python Dataflow ValidatesContainer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1310950671
# [Codecov](https://codecov.io/gh/apache/beam/pull/24099?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24099](https://codecov.io/gh/apache/beam/pull/24099?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb62e99) into [master](https://codecov.io/gh/apache/beam/commit/df553d1a4c6c6cc9b37ada2a6c84c88d8aef38b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df553d1) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24099 +/- ##
==========================================
- Coverage 73.32% 73.31% -0.01%
==========================================
Files 714 714
Lines 96429 96442 +13
==========================================
+ Hits 70707 70710 +3
- Misses 24401 24411 +10
Partials 1321 1321
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.19% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/24099?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...hon/apache\_beam/runners/worker/worker\_pool\_main.py](https://codecov.io/gh/apache/beam/pull/24099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3Bvb2xfbWFpbi5weQ==) | `56.32% <0.00%> (-2.94%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/24099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `95.12% <0.00%> (-2.44%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/24099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.30% <0.00%> (-0.38%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/24099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.08% <0.00%> (-0.17%)` | :arrow_down: |
| [sdks/python/apache\_beam/pipeline.py](https://codecov.io/gh/apache/beam/pull/24099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcGlwZWxpbmUucHk=) | `92.27% <0.00%> (+0.02%)` | :arrow_up: |
| [sdks/python/apache\_beam/ml/inference/base.py](https://codecov.io/gh/apache/beam/pull/24099/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvaW5mZXJlbmNlL2Jhc2UucHk=) | `95.76% <0.00%> (+0.11%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1310999960
Run Python Dataflow ValidatesContainer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1312291314
cc: @robertwb fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1311137959
Run Python Dataflow ValidatesContainer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1311000755
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1310999788
R: @tvalentyn
I was trying to figure out if we should use the prebuild_sdk_container_engine flag in this test. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1312290107
thanks.
verified sibling protocol is enabled in runner harness container:
```
"args": [ "--endpoint=https://dataflow.googleapis.com/", "--log_file=/var/log/dataflow/boot-json.log", "--log_dir=/var/log/dataflow", "--logging_port=12370", "--control_port=12371", "--provision_endpoint=localhost:12373", "--sdk_harness_ids=sdk-0-0,gcr.io/cloud-dataflow/v1beta3/python37:beam-master-20221021", "--enable_sibling_sdk_workers", "--sdk_harness_to_env_ids=sdk-0-0,,,ref_Environment_default_environment_1", "--num_threads_per_worker=2" ],
"image": "gcr.io/cloud-dataflow/v1beta3/unified-harness:20221026-14-rc00",
```
by running
```
python -m pytest -o log_cli=True -o log_level=Info apache_beam/examples/wordcount_it_test.py::WordCountIT::test_wordcount_it_with_use_sibling_sdk_workers --test-pipeline-options='--runner=TestDataflowRunner --project=apache-beam-testing --temp_location=gs://valentyn-testing --sdk_location=dist/apache-beam-2.44.0.dev0.tar.gz --region=us-central1 --output=gs://valentyn-testing/out'
```
and checking the container manifest for the running job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
tvalentyn merged PR #24099:
URL: https://github.com/apache/beam/pull/24099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on pull request #24099: Add a ValidatesContainer integration test for use_sibling_sdk_workers
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on PR #24099:
URL: https://github.com/apache/beam/pull/24099#issuecomment-1311009862
Run Python Dataflow ValidatesContainer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org