You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pkarashchenko (via GitHub)" <gi...@apache.org> on 2023/04/26 07:25:27 UTC
[GitHub] [nuttx] pkarashchenko opened a new pull request, #9104: sched/clock: do not initialize internal RTC if external RTC is selected
pkarashchenko opened a new pull request, #9104:
URL: https://github.com/apache/nuttx/pull/9104
## Summary
Do not initialize internal RTC if external RTC is selected
## Impact
Fix reported bug
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #9104: sched/clock: do not initialize internal RTC if external RTC is selected
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #9104:
URL: https://github.com/apache/nuttx/pull/9104#issuecomment-1598822730
Also there are some LEGACY PINMAP, please update the pins to use new name because LEGACY PINMAP will be removed.
I had to do it here: https://github.com/apache/nuttx/pull/9562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] btashton commented on pull request #9104: sched/clock: do not initialize internal RTC if external RTC is selected
Posted by "btashton (via GitHub)" <gi...@apache.org>.
btashton commented on PR #9104:
URL: https://github.com/apache/nuttx/pull/9104#issuecomment-1523625436
> Btw this is something I proposed about a month ago in [this email](https://lists.apache.org/thread/y7zrsbf2k86n1qbjlt67hlcj10smjdfw) and a response from @liguiding suggests up_rtc_initalize() should be called even if `CONFIG_RTC_EXTERNAL` is defined. Although I am still not sure this is entirely true and I agree with putting it under `!defined(CONFIG_RTC_EXTERNAL)`
I don't think I agree with that email for the reason given in the docs I linked. The required subsystems may very well not be ready by the time the clocks are being initialized. It is better to instead make this the job of the board initialization logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] michallenc commented on pull request #9104: sched/clock: do not initialize internal RTC if external RTC is selected
Posted by "michallenc (via GitHub)" <gi...@apache.org>.
michallenc commented on PR #9104:
URL: https://github.com/apache/nuttx/pull/9104#issuecomment-1523579866
Please also add `!defined(CONFIG_RTC_EXTERNAL)` to `up_rtc_initialize` function declaration in include/nuttx/arch.h.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] btashton commented on pull request #9104: sched/clock: do not initialize internal RTC if external RTC is selected
Posted by "btashton (via GitHub)" <gi...@apache.org>.
btashton commented on PR #9104:
URL: https://github.com/apache/nuttx/pull/9104#issuecomment-1523652338
Looks like this regression came as part of this
https://github.com/apache/nuttx/pull/5232/commits/6d1ff714c679595e71755e585b8cc35bcf38110e
So if we keep this proposed PR (which I am in favor of) we do need to modify sim to call the rtc initialization to not break rpmsg configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] michallenc commented on pull request #9104: sched/clock: do not initialize internal RTC if external RTC is selected
Posted by "michallenc (via GitHub)" <gi...@apache.org>.
michallenc commented on PR #9104:
URL: https://github.com/apache/nuttx/pull/9104#issuecomment-1523633751
> > Btw this is something I proposed about a month ago in [this email](https://lists.apache.org/thread/y7zrsbf2k86n1qbjlt67hlcj10smjdfw) and a response from @liguiding suggests up_rtc_initalize() should be called even if `CONFIG_RTC_EXTERNAL` is defined. Although I am still not sure this is entirely true and I agree with putting it under `!defined(CONFIG_RTC_EXTERNAL)`
>
> I don't think I agree with that email for the reason given in the docs I linked. The required subsystems may very well not be ready by the time the clocks are being initialized. It is better to instead make this the job of the board initialization logic.
Yes, those were my thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] michallenc commented on pull request #9104: sched/clock: do not initialize internal RTC if external RTC is selected
Posted by "michallenc (via GitHub)" <gi...@apache.org>.
michallenc commented on PR #9104:
URL: https://github.com/apache/nuttx/pull/9104#issuecomment-1523587140
Btw this is something I proposed about a month ago in [this email](https://lists.apache.org/thread/y7zrsbf2k86n1qbjlt67hlcj10smjdfw) and a response from @liguiding suggests up_rtc_initalize() should be kept even if `CONFIG_RTC_EXTERNAL` is defined. Although I am still not sure this is entirely true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org