You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "justinmclean (via GitHub)" <gi...@apache.org> on 2026/10/20 00:11:15 UTC
[PR] fix(mcp): document allowed values for poll strategy and partitioning [iggy]
justinmclean opened a new pull request, #4588:
URL: https://github.com/apache/iggy/pull/4588
## Which issue does this PR address?
Closes #4580
## Rationale
Agents calling `poll_messages` and `send_messages` cannot see which `strategy` and `partitioning` values are accepted, and a wrong guess silently falls back to a default.
## What changed?
The `strategy` and `partitioning` parameters were described only as "optional, string", and the `offset`, `timestamp`, `partition_id` and `messages_key` descriptions did not say when they apply.
The schema descriptions in `core/ai/mcp/src/service/requests.rs` now list the accepted values, the defaults, the fallback on unknown values, that `next` always commits the offset, and which strategy or partitioning each related field belongs to. Behaviour is unchanged.
## Local Execution
- Passed: `cargo fmt --all -- --check` on the pinned 1.99.0 toolchain, `cargo clippy -p iggy-mcp --all-targets -- -D warnings`, and the MCP integration tests `should_list_tools`, `should_poll_messages` and `should_send_messages`.
- Pre-commit hooks ran
## AI Usage
1. Claude (claude.ai and Claude Code).
2. Wrote the description changes after reading the parsing code in `core/ai/mcp/src/service/mod.rs`.
3. Checked each description against that parsing code, and ran the checks listed above.
4. Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mcp): document allowed values for poll strategy and partitioning [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4588:
URL: https://github.com/apache/iggy/pull/4588#issuecomment-6280599891
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/4588?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 69.80%. Comparing base ([`d1fe677`](https://app.codecov.io/gh/apache/iggy/commit/d1fe677db5c286f18a3823e25c37339d15e33ba8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3e208ba`](https://app.codecov.io/gh/apache/iggy/commit/3e208ba065e196cc2b6b3485f500843a6a1a6ac8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4588 +/- ##
=============================================
- Coverage 89.07% 69.80% -19.28%
Complexity 1785 1785
=============================================
Files 1330 1272 -58
Lines 286764 163272 -123492
Branches 245211 121719 -123492
=============================================
- Hits 255447 113976 -141471
- Misses 25712 43983 +18271
+ Partials 5605 5313 -292
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.00% <ø> (-24.77%)` | :arrow_down: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.75% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.43% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.43% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `86.02% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `95.12% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.86% <ø> (ø)` | |
| [C++ SDK](https://app.codecov.io/gh/apache/iggy/pull/4588/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.44% <ø> (ø)` | |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/4588?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/ai/mcp/src/service/requests.rs](https://app.codecov.io/gh/apache/iggy/pull/4588?src=pr&el=tree&filepath=core%2Fai%2Fmcp%2Fsrc%2Fservice%2Frequests.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9haS9tY3Avc3JjL3NlcnZpY2UvcmVxdWVzdHMucnM=) | `100.00% <ø> (ø)` | |
... and [548 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/4588/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mcp): document allowed values for poll strategy and partitioning [iggy]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4588:
URL: https://github.com/apache/iggy/pull/4588#issuecomment-6280188538
<!-- iggy-pr-triage-welcome -->
Thanks for the PR. It is labeled `S-waiting-on-review` and queued for review.
Slash commands (own line, regular comment) move it around the queue:
- `/ready` - back to `S-waiting-on-review` after addressing feedback
- `/author` - flip to `S-waiting-on-author` while you finish changes
- `/request-review @user-or-team` - request a reviewer
- `/pin` - exempt the PR from the stale bot, `/unpin` to undo
See [CONTRIBUTING.md](https://github.com/apache/iggy/blob/master/CONTRIBUTING.md#pr-triage-commands) for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(mcp): document allowed values for poll strategy and partitioning [iggy]
Posted by "ByteBaker (via GitHub)" <gi...@apache.org>.
ByteBaker commented on code in PR #4588:
URL: https://github.com/apache/iggy/pull/4588#discussion_r4342106058
##########
core/ai/mcp/src/service/requests.rs:
##########
@@ -178,13 +178,22 @@ pub struct PollMessages {
#[schemars(description = "partition identifier (optional, number)")]
pub partition_id: Option<u32>,
- #[schemars(description = "strategy (optional, string)")]
+ #[schemars(
+ description = "polling strategy (optional, one of 'offset', 'first', 'last', 'next', \
+ 'timestamp'; defaults to 'offset'; 'next' resumes from the stored consumer \
+ offset and always auto-commits; unknown values fall back to 'offset')"
+ )]
pub strategy: Option<String>,
Review Comment:
A potential TODO for the future. This needs to be an enum, and the docs should reflect that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org