You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bval.apache.org by "Carlos Vara (JIRA)" <ji...@apache.org> on 2010/04/21 17:41:50 UTC

[jira] Created: (BVAL-21) ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()

ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()
-------------------------------------------------------------------------------------------------------

                 Key: BVAL-21
                 URL: https://issues.apache.org/jira/browse/BVAL-21
             Project: BeanValidation
          Issue Type: Bug
          Components: jsr303
    Affects Versions: 0.1-incubating
            Reporter: Carlos Vara


The returning set of ConstraintViolations should not have duplicate entries, so equals must be defined in ConstraintViolationImpl.
Also, two ConstraintViolations with all equal fields except the way they access the property should be considered different, so ConstraintViolationImpl should store the ElementType and compare it in the equals() method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (BVAL-21) ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()

Posted by "Roman Stumm (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BVAL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on BVAL-21 started by Roman Stumm.

> ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()
> -------------------------------------------------------------------------------------------------------
>
>                 Key: BVAL-21
>                 URL: https://issues.apache.org/jira/browse/BVAL-21
>             Project: BeanValidation
>          Issue Type: Bug
>          Components: jsr303
>    Affects Versions: 0.1-incubating
>            Reporter: Carlos Vara
>            Assignee: Roman Stumm
>         Attachments: bval-core.patch, bval-jsr303.patch
>
>
> The returning set of ConstraintViolations should not have duplicate entries, so equals must be defined in ConstraintViolationImpl.
> Also, two ConstraintViolations with all equal fields except the way they access the property should be considered different, so ConstraintViolationImpl should store the ElementType and compare it in the equals() method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BVAL-21) ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()

Posted by "Carlos Vara (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BVAL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Vara updated BVAL-21:
----------------------------

    Attachment: bval-core.patch
                bval-jsr303.patch

Patches for bval-core and bval-jsr303 attached.

Added equals() and hashCode() methods in ConstraintViolationImpl.
Added getAccess() method in the signature of ValidationContext to allow access to it when building a new ConstraintViolation.

2 more TCK tests pass.

> ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()
> -------------------------------------------------------------------------------------------------------
>
>                 Key: BVAL-21
>                 URL: https://issues.apache.org/jira/browse/BVAL-21
>             Project: BeanValidation
>          Issue Type: Bug
>          Components: jsr303
>    Affects Versions: 0.1-incubating
>            Reporter: Carlos Vara
>         Attachments: bval-core.patch, bval-jsr303.patch
>
>
> The returning set of ConstraintViolations should not have duplicate entries, so equals must be defined in ConstraintViolationImpl.
> Also, two ConstraintViolations with all equal fields except the way they access the property should be considered different, so ConstraintViolationImpl should store the ElementType and compare it in the equals() method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BVAL-21) ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()

Posted by "Roman Stumm (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BVAL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Stumm updated BVAL-21:
----------------------------

    Fix Version/s: 0.1-incubating

> ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()
> -------------------------------------------------------------------------------------------------------
>
>                 Key: BVAL-21
>                 URL: https://issues.apache.org/jira/browse/BVAL-21
>             Project: BeanValidation
>          Issue Type: Bug
>          Components: jsr303
>    Affects Versions: 0.1-incubating
>            Reporter: Carlos Vara
>            Assignee: Roman Stumm
>             Fix For: 0.1-incubating
>
>         Attachments: bval-core.patch, bval-jsr303.patch
>
>
> The returning set of ConstraintViolations should not have duplicate entries, so equals must be defined in ConstraintViolationImpl.
> Also, two ConstraintViolations with all equal fields except the way they access the property should be considered different, so ConstraintViolationImpl should store the ElementType and compare it in the equals() method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (BVAL-21) ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()

Posted by "Roman Stumm (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BVAL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Stumm reassigned BVAL-21:
-------------------------------

    Assignee: Roman Stumm

> ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()
> -------------------------------------------------------------------------------------------------------
>
>                 Key: BVAL-21
>                 URL: https://issues.apache.org/jira/browse/BVAL-21
>             Project: BeanValidation
>          Issue Type: Bug
>          Components: jsr303
>    Affects Versions: 0.1-incubating
>            Reporter: Carlos Vara
>            Assignee: Roman Stumm
>         Attachments: bval-core.patch, bval-jsr303.patch
>
>
> The returning set of ConstraintViolations should not have duplicate entries, so equals must be defined in ConstraintViolationImpl.
> Also, two ConstraintViolations with all equal fields except the way they access the property should be considered different, so ConstraintViolationImpl should store the ElementType and compare it in the equals() method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BVAL-21) ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()

Posted by "Roman Stumm (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BVAL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Stumm resolved BVAL-21.
-----------------------------

    Resolution: Fixed

merged patches and committed them together with another fix (BVAL-13)

> ConstraintViolations set should not have duplicates and should store ElementType and use it in equals()
> -------------------------------------------------------------------------------------------------------
>
>                 Key: BVAL-21
>                 URL: https://issues.apache.org/jira/browse/BVAL-21
>             Project: BeanValidation
>          Issue Type: Bug
>          Components: jsr303
>    Affects Versions: 0.1-incubating
>            Reporter: Carlos Vara
>            Assignee: Roman Stumm
>         Attachments: bval-core.patch, bval-jsr303.patch
>
>
> The returning set of ConstraintViolations should not have duplicate entries, so equals must be defined in ConstraintViolationImpl.
> Also, two ConstraintViolations with all equal fields except the way they access the property should be considered different, so ConstraintViolationImpl should store the ElementType and compare it in the equals() method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.