You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/07/06 07:24:52 UTC
[GitHub] [hudi] wangxianghu opened a new pull request #3229: [HUDI-2120] Update docs about schema in flink sql configuration
wangxianghu opened a new pull request #3229:
URL: https://github.com/apache/hudi/pull/3229
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
follow up of https://github.com/apache/hudi/commit/f2621da32f33bf16fb53f8a71eaf7bca24e6d166
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #3229:
URL: https://github.com/apache/hudi/pull/3229#issuecomment-898348042
> @wangxianghu can we rework this based off the new site?
@vinothchandar
done, sorry for the big delay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu closed pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration
Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #3229:
URL: https://github.com/apache/hudi/pull/3229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3229:
URL: https://github.com/apache/hudi/pull/3229#issuecomment-874552723
# [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`asf-site@a777ff9`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head f2621da differs from pull request most recent head 7646391. Consider uploading reports for the commit 7646391 to get more accurate results
[](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## asf-site #3229 +/- ##
===========================================
Coverage ? 27.38%
Complexity ? 1275
===========================================
Files ? 376
Lines ? 15079
Branches ? 1304
===========================================
Hits ? 4130
Misses ? 10651
Partials ? 298
```
| Flag | Coverage Δ | |
|---|---|---|
| hudiclient | `21.01% <0.00%> (?)` | |
| hudisync | `5.28% <0.00%> (?)` | |
| hudiutilities | `58.59% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a777ff9...7646391](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3229:
URL: https://github.com/apache/hudi/pull/3229#issuecomment-892162164
@wangxianghu can we rework this based off the new site?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #3229:
URL: https://github.com/apache/hudi/pull/3229#issuecomment-915942188
Fixed already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3229:
URL: https://github.com/apache/hudi/pull/3229#issuecomment-874552723
# [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`asf-site@a777ff9`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head f2621da differs from pull request most recent head 7646391. Consider uploading reports for the commit 7646391 to get more accurate results
[](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## asf-site #3229 +/- ##
===========================================
Coverage ? 47.61%
Complexity ? 5487
===========================================
Files ? 924
Lines ? 41206
Branches ? 4134
===========================================
Hits ? 19621
Misses ? 19843
Partials ? 1742
```
| Flag | Coverage Δ | |
|---|---|---|
| hudicli | `39.97% <0.00%> (?)` | |
| hudiclient | `34.58% <0.00%> (?)` | |
| hudicommon | `48.58% <0.00%> (?)` | |
| hudiflink | `59.58% <0.00%> (?)` | |
| hudihadoopmr | `51.29% <0.00%> (?)` | |
| hudisparkdatasource | `67.33% <0.00%> (?)` | |
| hudisync | `54.48% <0.00%> (?)` | |
| huditimelineservice | `64.07% <0.00%> (?)` | |
| hudiutilities | `58.59% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a777ff9...7646391](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter edited a comment on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3229:
URL: https://github.com/apache/hudi/pull/3229#issuecomment-874552723
# [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`asf-site@a777ff9`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head f2621da differs from pull request most recent head 7646391. Consider uploading reports for the commit 7646391 to get more accurate results
[](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## asf-site #3229 +/- ##
===========================================
Coverage ? 47.61%
Complexity ? 5487
===========================================
Files ? 924
Lines ? 41206
Branches ? 4134
===========================================
Hits ? 19621
Misses ? 19843
Partials ? 1742
```
| Flag | Coverage Δ | |
|---|---|---|
| hudicli | `39.97% <0.00%> (?)` | |
| hudiclient | `34.58% <0.00%> (?)` | |
| hudicommon | `48.58% <0.00%> (?)` | |
| hudiflink | `59.58% <0.00%> (?)` | |
| hudihadoopmr | `51.29% <0.00%> (?)` | |
| hudisparkdatasource | `67.33% <0.00%> (?)` | |
| hudisync | `54.48% <0.00%> (?)` | |
| huditimelineservice | `64.07% <0.00%> (?)` | |
| hudiutilities | `58.59% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a777ff9...7646391](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-commenter commented on pull request #3229: [HUDI-2120] [DOC] Update docs about schema in flink sql configuration
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3229:
URL: https://github.com/apache/hudi/pull/3229#issuecomment-874552723
# [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`asf-site@a777ff9`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
> :exclamation: Current head f2621da differs from pull request most recent head 7646391. Consider uploading reports for the commit 7646391 to get more accurate results
[](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## asf-site #3229 +/- ##
===========================================
Coverage ? 27.38%
Complexity ? 1275
===========================================
Files ? 376
Lines ? 15079
Branches ? 1304
===========================================
Hits ? 4130
Misses ? 10651
Partials ? 298
```
| Flag | Coverage Δ | |
|---|---|---|
| hudiclient | `21.01% <0.00%> (?)` | |
| hudisync | `5.28% <0.00%> (?)` | |
| hudiutilities | `58.59% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a777ff9...7646391](https://codecov.io/gh/apache/hudi/pull/3229?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org