You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/12 18:21:20 UTC
[GitHub] [airflow] phanikumv opened a new pull request, #25699: Fix aws cli installation script
phanikumv opened a new pull request, #25699:
URL: https://github.com/apache/airflow/pull/25699
When I try to install aws cli on local breeze container using `install_aws.sh` , it is downloading wrong version of aws cli, and hence my DAG gives below error.
`2022-08-12, 17:50:27 UTC] {subprocess.py:74} INFO - Running command: ['/bin/bash', '-c', 'aws configure set aws_access_key_id xxxxxxx; aws configure set aws_secret_access_key xxxxxxxx; aws configure set default.region us-east-2; ']
[2022-08-12, 17:50:27 UTC] {subprocess.py:85} INFO - Output:
[2022-08-12, 17:50:27 UTC] {subprocess.py:92} INFO - qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory`
The reason is because the `install_aws.sh` script takes wrong download URL for `aarch64` OS version.
This PR corrects the download URL based on underlying OS version on the container.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a diff in pull request #25699: Fix aws cli installation script
Posted by GitBox <gi...@apache.org>.
feluelle commented on code in PR #25699:
URL: https://github.com/apache/airflow/pull/25699#discussion_r946481772
##########
scripts/in_container/bin/install_aws.sh:
##########
@@ -35,7 +35,11 @@ if command -v aws; then
exit 1
fi
-DOWNLOAD_URL="https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip"
+if [[ $(uname -m) == "arm64" || $(uname -m) == "aarch64" ]]; then
Review Comment:
```suggestion
HOST=$(uname -m)
if [[ ${HOST} == "arm64" || ${HOST} == "aarch64" ]]; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] phanikumv commented on a diff in pull request #25699: Fix aws cli installation script
Posted by GitBox <gi...@apache.org>.
phanikumv commented on code in PR #25699:
URL: https://github.com/apache/airflow/pull/25699#discussion_r946630471
##########
scripts/in_container/bin/install_aws.sh:
##########
@@ -35,7 +35,11 @@ if command -v aws; then
exit 1
fi
-DOWNLOAD_URL="https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip"
+if [[ $(uname -m) == "arm64" || $(uname -m) == "aarch64" ]]; then
Review Comment:
@feluelle I have applied this change.Could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25699: Fix aws cli installation script
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25699:
URL: https://github.com/apache/airflow/pull/25699#issuecomment-1216860288
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #25699: Fix aws cli installation script
Posted by GitBox <gi...@apache.org>.
ashb merged PR #25699:
URL: https://github.com/apache/airflow/pull/25699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org