[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4702: armv7-m,armv7-r,armv8-m:MPU Add mpu_reset and ARM_MPU_EARLY_RESET

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #4702:
URL: https://github.com/apache/incubator-nuttx/pull/4702#discussion_r733860617



##########
File path: arch/arm/src/stm32/stm32_mpuinit.h
##########
@@ -72,4 +72,19 @@ void stm32_mpu_uheap(uintptr_t start, size_t size);
 #  define stm32_mpu_uheap(start,size)
 #endif
 
+/****************************************************************************
+ * Name: stm32_mpu_early_reset
+ *
+ * Description:
+ *   Resets the MPU to disabled.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ARM_MPU_EARLY_RESET

Review comment:
       why not define a general mpu_early_reset to mpu_reset or empty base on CONFIG_ARM_MPU_EARLY_RESET directly?

##########
File path: arch/arm/src/stm32/stm32_mpuinit.c
##########
@@ -78,6 +78,12 @@ void stm32_mpuinitialize(void)
 
   mpu_showtype();
 
+#if defined(CONFIG_MPU_RESET)
+  /* Reset MPU if enabled */
+
+  mpu_reset();

Review comment:
       why not define an empty mpu_reset in mpu.h when CONFIG_MPU_RESET equals n?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org