[GitHub] [beam] Abacn commented on a diff in pull request #26193: [Feature Request]: Support detached mode for flink runner (#26158)

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #26193:
URL: https://github.com/apache/beam/pull/26193#discussion_r1164825595


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineOptions.java:
##########
@@ -142,6 +142,20 @@
 
   void setNumberOfExecutionRetries(Integer retries);
 
+  @Description(
+      "Set job check interval in seconds under detached mode in method waitUntilFinish, "
+          + "by default it is 5 seconds")
+  @Default.Integer(5)
+  int getJobCheckIntervalInSecs();
+
+  void setJobCheckIntervalInSecs(int seconds);
+
+  @Description("Set the attached mode")
+  @Default.Boolean(true)
+  boolean getAttachedMode();

Review Comment:
   There is a setBlockOnRun option for DirectRunner: https://github.com/apache/beam/blob/4ffeae4d2b800f2df36d2ea2eab549f2204d5691/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectOptions.java#L36
   
   could use the same naming



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org