[jira] Commented: (GERONIMO-1265) Preserve comments added by users in the config.xml file

["Jay D. McHugh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GERONIMO-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559176#action_12559176 ] 

Jay D. McHugh commented on GERONIMO-1265:
-----------------------------------------

After considering this some more - I don't think it is necessary for us to be able to do either of the 'todo' items above (especially not #1).

Comments are retained for each level of the config.xml file.

And if they are added to the pom.xml's in source (in the '<config-xml-content>' section) then they are carried into the generated config.xml for the server.

Is there anyone who specifically wants to be able to do either of the 'todo' items above?

If not, then I am going to go ahead and close this issue.

> Preserve comments added by users in the config.xml file
> -------------------------------------------------------
>
>                 Key: GERONIMO-1265
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-1265
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: startup/shutdown, usability
>    Affects Versions: 1.0-M5, 1.0, 1.1, 2.1
>            Reporter: John Sisson
>            Assignee: Jay D. McHugh
>         Attachments: geronimo-1265.patch
>
>
> Currently if a user adds comments to the config.xml file, they will be lost when Geronimo re-generates the file if a configuration change is made (e.g. through the web console).
> As a temporary measure, the code that re-generates the XML will place a warning at the top of the file warning users not to place comments in it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.