[GitHub] [zookeeper] lhotari commented on a change in pull request #1770: Netty server does not respond to ruok while initializing cluster

[GitBox <gi...@apache.org>]

lhotari commented on a change in pull request #1770:
URL: https://github.com/apache/zookeeper/pull/1770#discussion_r778804659



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
##########
@@ -521,11 +525,16 @@ private void receiveMessage(ByteBuf message) {
                             throw new IOException("Len error " + len);
                         }
                         ZooKeeperServer zks = this.zkServer;
-                        if (zks == null || !zks.isRunning()) {
-                            throw new IOException("ZK down");
+
+                        if (zks != null && !zks.isRunning()) {

Review comment:
       Is the condition correct? I'd assume that the condition would be `zks.isRunning()`.
   ```suggestion
                           if (zks != null && zks.isRunning()) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org