[GitHub] [airflow] bbovenzi commented on pull request #17821: Improve graph view load time for dags with open groups

[GitBox <gi...@apache.org>]

bbovenzi commented on pull request #17821:
URL: https://github.com/apache/airflow/pull/17821#issuecomment-906248066


   Oh I'm sorry to make you write all that up I guess I was just trying to find an example where it was noticaebly slower to render.
   
   This looks good but I think we can clean it up a little more. There is only one time we call `expandGroup()` (line 153) and want to focus and draw. Instead of carrying around these variables and calling `draw` and `focusGroup` inside of `expandGroup` we just call those two functions immediately after expandGroup in that one situation. Like so
   
   ``` 
   expandGroup(nodeId, node);
         draw();
         focusGroup(nodeId);```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org