[GitHub] [maven] gnodet commented on a diff in pull request #1100: [MNG-7038] Fixes for topDirectory

["gnodet (via GitHub)" <gi...@apache.org>]

gnodet commented on code in PR #1100:
URL: https://github.com/apache/maven/pull/1100#discussion_r1182837938


##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -332,10 +332,10 @@ void initialize(CliRequest cliRequest) throws ExitException {
         for (String arg : cliRequest.args) {
             if (isAltFile) {
                 // this is the argument following -f/--file
-                Path path = Paths.get(arg);
+                Path path = topDirectory.resolve(arg);

Review Comment:
   That's really weird.  That would make file argument order dependent as the `topDirectory` is modified inside the loop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org