You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by brkolla <gi...@git.apache.org> on 2016/09/21 19:24:11 UTC
[GitHub] couchdb-couch-mrview pull request #57: Add new function to get the view inde...
GitHub user brkolla opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/57
Add new function to get the view index pid.
Refactored the code to add a new function to return index pid for a
given view and design document.
COUCHDB-3150
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch-mrview COUCHDB-3150-add-new-function-to-get-view-index-pid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-mrview/pull/57.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #57
----
commit 80780c8dee6ec9f14b4aa6a76d72356b7e488c7d
Author: brkolla <bk...@cloudant.com>
Date: 2016-09-21T18:52:57Z
Add new function to get the view index pid.
Refactored the code to add a new function to return index pid for a
given view and design document.
COUCHDB-3150
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request #57: Add new function to get the view inde...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-mrview/pull/57
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview issue #57: Add new function to get the view index pid.
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/57
The patch does what it says it should, so that's fine. I'm concerned about fabric calling directly into couch_mrview_util, though. In other applications, fabric for example, we insist on an 'entry' module to allow future refactorings. So, for fabric, other applications should only ever call functions in fabric.erl. I think we should adopt that pattern here. @davisp what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview issue #57: Add new function to get the view index pid.
Posted by brkolla <gi...@git.apache.org>.
Github user brkolla commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/57
Sounds like a good pattern to follow. I can add a function in `couch_mrview` and update `fabric_rpc` to call couch_mrview module, which in turn will call the function in couch_mrview_util.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview issue #57: Add new function to get the view index pid.
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/57
+1 but let's only merge once the other PR is ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview issue #57: Add new function to get the view index pid.
Posted by brkolla <gi...@git.apache.org>.
Github user brkolla commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/57
@rnewson Have updated the code to make sure that I call into couch_mrview module and not call directly into cocuh_mrview_util
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview issue #57: Add new function to get the view index pid.
Posted by brkolla <gi...@git.apache.org>.
Github user brkolla commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/57
@rnewson @davisp. Can you please review this too. This change is also related to triggering an update with stale=update_after
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---