[jira] [Commented] (CRUNCH-185) Make the MemPipeline#done return a PipelineResult with the Counters inside.

["Josh Wills (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CRUNCH-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614704#comment-13614704 ] 

Josh Wills commented on CRUNCH-185:
-----------------------------------

Looks good to me, with a small nit/question: should MemPipeline.clearCounters() return the COUNTERS object? Or should it just be a void method?
                
> Make the MemPipeline#done return a PipelineResult with the Counters inside.
> ---------------------------------------------------------------------------
>
>                 Key: CRUNCH-185
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-185
>             Project: Crunch
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Christian Tzolov
>            Assignee: Christian Tzolov
>            Priority: Minor
>         Attachments: CRUNCH-185.patch
>
>
> The MRPipeline exposes the job counters via the PipelineResult. The MemPipeline behaves differently. It always returns an EMPTY PipelineResult and exposes a static getCounters() method. 
> To make both implementations behave alike the MemPipeline should return a single-staged PipelineResult containing the Counters. 
> Also the MemPipeline should provide a mechanism to reset the Counters. At the moment there is no other mechanism to reset but restarting the application.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira