You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2025/06/30 15:15:22 UTC
Re: [PR] [SPARK-52612][INFRA] No longer explicitly add the `spark-avro-*.jar` to the classpath of the benchmark. [spark]
LuciferYang commented on code in PR #51321:
URL: https://github.com/apache/spark/pull/51321#discussion_r2175325669
##########
.github/workflows/benchmark.yml:
##########
@@ -189,7 +189,7 @@ jobs:
# In benchmark, we use local as master so set driver memory only. Note that GitHub Actions has 7 GB memory limit.
bin/spark-submit \
--driver-memory 6g --class org.apache.spark.benchmark.Benchmarks \
- --jars "`find . -name '*-SNAPSHOT-tests.jar' -o -name '*avro*-SNAPSHOT.jar' | paste -sd ',' -`,`find ~/.cache/coursier -name 'curator-test-*.jar'`" \
+ --jars "`find . -name '*-SNAPSHOT-tests.jar' | paste -sd ',' -`,`find ~/.cache/coursier -name 'curator-test-*.jar'`" \
Review Comment:
Both the jars directories generated by `sbt/package` and `dev/make-distribution.sh --tgz --sbt-enabled` will include `spark-avro_*.jar` and `spark-protobuf_*.jar`. However, the output from `dev/make-distribution.sh --tgz` does not include them.
I plan to accept their presence and instead fix `benchmark.xml`: removing the explicit action of adding `spark-avro_*.jar` to the classpath.
After that, I will explore ways to ensure that the jars outputs from `dev/make-distribution.sh --tgz --sbt-enabled` and `dev/make-distribution.sh --tgz` are identical.
##########
.github/workflows/benchmark.yml:
##########
@@ -189,7 +189,7 @@ jobs:
# In benchmark, we use local as master so set driver memory only. Note that GitHub Actions has 7 GB memory limit.
bin/spark-submit \
--driver-memory 6g --class org.apache.spark.benchmark.Benchmarks \
- --jars "`find . -name '*-SNAPSHOT-tests.jar' -o -name '*avro*-SNAPSHOT.jar' | paste -sd ',' -`,`find ~/.cache/coursier -name 'curator-test-*.jar'`" \
+ --jars "`find . -name '*-SNAPSHOT-tests.jar' | paste -sd ',' -`,`find ~/.cache/coursier -name 'curator-test-*.jar'`" \
Review Comment:
Both the jars directories generated by `sbt/package` and `dev/make-distribution.sh --tgz --sbt-enabled` will include `spark-avro_*.jar` and `spark-protobuf_*.jar`. However, the output from `dev/make-distribution.sh --tgz` does not include them.
I plan to accept their presence and instead fix `benchmark.xml`: removing the explicit action of adding `spark-avro_*.jar` to the classpath.
After that, I will explore ways to ensure that the jars outputs from `dev/make-distribution.sh --tgz --sbt-enabled` and `dev/make-distribution.sh --tgz` are identical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org