[GitHub] jvrao commented on a change in pull request #266: Issue 265: Add persistable bookie status

[gi...@git.apache.org]

jvrao commented on a change in pull request #266: Issue 265: Add persistable bookie status
URL: https://github.com/apache/bookkeeper/pull/266#discussion_r140661378
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java
 ##########
 @@ -857,7 +884,13 @@ public synchronized void start() {
 
         ledgerStorage.start();
 
-        syncThread.start();
+        // check the bookie status to start with
+        if (forceReadOnly.get()) {
 
 Review comment:
   So force is only one-way operation; we have no forceWrite option. i.e if bookieStatus says readonly there is no way to start bookie in RW until we change bookieStatus. I am still at large don't understand the need of this change, but as long as we document it well, I am fine. I think it is mostly an operational overhead than letting operational scripts deal with starting bookie in R/RW.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services