You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "cdfive (GitHub)" <gi...@apache.org> on 2019/01/02 15:39:05 UTC

[GitHub] [incubator-dubbo-website] cdfive commented on issue #226: Update copyright year display in the bottom of site page #224

@Ruffianjiang @ralf0131 
Considering the user's local time, I add fault-tolerant judgment:
`((new Date().getFullYear() > 2018) ? ('-' + new Date().getFullYear()) : '')`

If the user's local time is moving backwards or has other errors,only the 2018 will be displayed.
The point is to need't modify when the year passed by, and in most condition is right.

But in indeed,I didn't test disabling JavaScript condition.

Also agree with that using static number is an easy and safe way,  the only “deficiency”
is that it needs to update next year.

By the way, the #225 add the 2019 for 'en-us', but the 'zh-cn' seems be omitted,  need to be added?








[ Full content available at: https://github.com/apache/incubator-dubbo-website/pull/226 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org