You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/07/07 15:36:53 UTC
[GitHub] [cordova-docs] breautek commented on a diff in pull request #1249: docs(core-features): migrate Android SplashScreen
breautek commented on code in PR #1249:
URL: https://github.com/apache/cordova-docs/pull/1249#discussion_r916015970
##########
www/docs/en/dev/core/features/splashscreen/index.md:
##########
@@ -351,12 +391,16 @@ Amount of time in milliseconds to wait before automatically hide splash screen.
**Supported Platforms:**
+- Android
- iOS
**Data Type:** `Number`, in milliseconds
**Default Value:** `true`
+- Android
+ `-1`: The splash screen will automatticly hide when the `onPageFinished` has been triggered.
+
- iOS
`3000`: The splash screen will automatticly hide in 3 seconds.
Review Comment:
```suggestion
`3000`: The splash screen will automatically hide in 3 seconds.
```
##########
www/docs/en/dev/core/features/splashscreen/index.md:
##########
@@ -366,6 +410,120 @@ Amount of time in milliseconds to wait before automatically hide splash screen.
<preference name="SplashScreenDelay" value="3000" />
```
+### `AndroidPostSplashScreenTheme`
+
+Sets the post-theme of the activity after splash screen hides.
+
+_Note:_ This setting is available but use at your own risk.
+
+**Supported Platforms:**
+
+- Android
+
+**Data Type:** `String`
+
+**Default Value:** `@style/Theme.AppCompat.NoActionBar`
+
+**Usage Example:**
+
+```xml
+<preference name="AndroidPostSplashScreenTheme" value="@style/Theme.AppCompat.NoActionBar"/>
+```
+
+### `AndroidWindowSplashScreenAnimatedIcon`
+
+The splash screen image. This preference is used for both animated and non-animated icons. The current acceptable asset files can either be an XML Vector Drwable or PNG.
+
+**Supported Platforms:**
+
+- Android
+
+**Data Type:** `String`, file path to the asset file
+
+**Default Value:** If not supplied, the Cordova's default asset is used.
+
+**Usage Example:**
+
+```xml
+<preference name="AndroidWindowSplashScreenAnimatedIcon" value="res/screen/android/splashscreen.xml" />
+```
+
+### `AndroidWindowSplashScreenAnimationDuration`
+
+Defines the duration of the icon's animation if an Animated Vector Drwable is supplied as the splash screen image.
Review Comment:
```suggestion
Defines the duration of the icon's animation if an Animated Vector Drawable is supplied as the splash screen image.
```
##########
www/docs/en/dev/core/features/splashscreen/index.md:
##########
@@ -366,6 +410,120 @@ Amount of time in milliseconds to wait before automatically hide splash screen.
<preference name="SplashScreenDelay" value="3000" />
```
+### `AndroidPostSplashScreenTheme`
+
+Sets the post-theme of the activity after splash screen hides.
+
+_Note:_ This setting is available but use at your own risk.
+
+**Supported Platforms:**
+
+- Android
+
+**Data Type:** `String`
+
+**Default Value:** `@style/Theme.AppCompat.NoActionBar`
+
+**Usage Example:**
+
+```xml
+<preference name="AndroidPostSplashScreenTheme" value="@style/Theme.AppCompat.NoActionBar"/>
+```
+
+### `AndroidWindowSplashScreenAnimatedIcon`
+
+The splash screen image. This preference is used for both animated and non-animated icons. The current acceptable asset files can either be an XML Vector Drwable or PNG.
Review Comment:
```suggestion
The splash screen image. This preference is used for both animated and non-animated icons. The current acceptable asset files can either be a XML Vector Drawable or PNG.
```
##########
www/docs/en/dev/core/features/splashscreen/index.md:
##########
@@ -351,12 +391,16 @@ Amount of time in milliseconds to wait before automatically hide splash screen.
**Supported Platforms:**
+- Android
- iOS
**Data Type:** `Number`, in milliseconds
**Default Value:** `true`
+- Android
+ `-1`: The splash screen will automatticly hide when the `onPageFinished` has been triggered.
Review Comment:
```suggestion
`-1`: The splash screen will automatically hide when the `onPageFinished` has been triggered.
```
##########
www/docs/en/11.x/core/features/splashscreen/index.md:
##########
@@ -351,12 +391,16 @@ Amount of time in milliseconds to wait before automatically hide splash screen.
**Supported Platforms:**
+- Android
- iOS
**Data Type:** `Number`, in milliseconds
**Default Value:** `true`
+- Android
+ `-1`: The splash screen will automatticly hide when the `onPageFinished` has been triggered.
+
- iOS
`3000`: The splash screen will automatticly hide in 3 seconds.
Review Comment:
```suggestion
`3000`: The splash screen will automatically hide in 3 seconds.
```
I know this wasn't changed in this PR, but has the same spelling mistake, so may as well correct it at the same time.
##########
www/docs/en/11.x/core/features/splashscreen/index.md:
##########
@@ -351,12 +391,16 @@ Amount of time in milliseconds to wait before automatically hide splash screen.
**Supported Platforms:**
+- Android
- iOS
**Data Type:** `Number`, in milliseconds
**Default Value:** `true`
+- Android
+ `-1`: The splash screen will automatticly hide when the `onPageFinished` has been triggered.
Review Comment:
```suggestion
`-1`: The splash screen will automatically hide when the `onPageFinished` has been triggered.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org