You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/05 21:24:09 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1481: ZOOKEEPER-3954: C client: GCC 10 compilation fixes
ztzg opened a new pull request #1481:
URL: https://github.com/apache/zookeeper/pull/1481
The most important change in this PR avoids a confusing and scary compilation issue [encountered by Michael Hudson-Doyle](https://issues.apache.org/jira/browse/ZOOKEEPER-3954) when building the C client with GCC 10 and "aggressive" optimization settings:
> `free_auth_completions` is being inlined into `free_completions`, and this lets gcc see that members of `a_list` are being accessed without initialization
This is (fortunately!) a red herring: what GCC doesn't see is that, in practice, `zoo_lock_auth` always returns zero, and that `a_list` is always initialized in the conditional block which follows it.
That issue is easily "fixed" by removing the `if`. The rest of the client code doesn't check `zoo_lock_auth`'s return value--and we have bigger issues if unconditional locks start failing anyway.
The remaining changes get rid of a couple of innocuous warnings, to that the client can successfully build even when configured with `-Werror`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] symat closed pull request #1481: ZOOKEEPER-3954: C client: GCC 10 compilation fixes
Posted by GitBox <gi...@apache.org>.
symat closed pull request #1481:
URL: https://github.com/apache/zookeeper/pull/1481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1481: ZOOKEEPER-3954: C client: GCC 10 compilation fixes
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1481:
URL: https://github.com/apache/zookeeper/pull/1481#issuecomment-706361637
Okay, noted. (But in this case, I just thought I'd push the branch as I had created it for testing anyway.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1481: ZOOKEEPER-3954: C client: GCC 10 compilation fixes
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1481:
URL: https://github.com/apache/zookeeper/pull/1481#issuecomment-704557446
> The best practice is to send the PR against master, then send amended patches for other active branches when needed.
Okay; here is [a patch against `master`](https://github.com/apache/zookeeper/pull/1487) and [one against `branch-3.6`](https://github.com/apache/zookeeper/pull/1486).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] ztzg commented on pull request #1481: ZOOKEEPER-3954: C client: GCC 10 compilation fixes
Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1481:
URL: https://github.com/apache/zookeeper/pull/1481#issuecomment-703898784
This PR is against the 3.5 branch, but the commits, once reviewed, should also be cherry-picked to 3.6 and (partially) to `master`. (Only the first commit is necessary on `master`; the other two create trivial conflicts because they have already been fixed there.)
Cc: @mwhudson, @eolivelli, @symat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1481: ZOOKEEPER-3954: C client: GCC 10 compilation fixes
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1481:
URL: https://github.com/apache/zookeeper/pull/1481#issuecomment-704035647
The best practice is to send the PR against master, then send amended patches for other active branches when needed.
Btw thank you very much for this fix.
Please send the patch for master as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org