You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/14 05:27:29 UTC

[GitHub] [superset] john-bodley commented on a change in pull request #16263: chore(pylint): Reenable import-outside-toplevel check

john-bodley commented on a change in pull request #16263:
URL: https://github.com/apache/superset/pull/16263#discussion_r688871812



##########
File path: superset/utils/core.py
##########
@@ -1258,16 +1257,15 @@ def get_or_create_db(
 
 
 def get_example_database() -> "Database":
-    from superset import conf
-
-    db_uri = conf.get("SQLALCHEMY_EXAMPLES_URI") or conf.get("SQLALCHEMY_DATABASE_URI")
+    db_uri = (

Review comment:
       I'm kind of surprised Mypy didn't pick up on this, i.e., the `db_uri` could be `None` though the `get_or_create_db` is expecting a `str` rather than `Optional[str]`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org